Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solver Handler not switching hands when tracking both left and right Interactors #11434

Closed
srinjoym opened this issue Mar 24, 2023 · 4 comments
Closed

Comments

@srinjoym
Copy link
Contributor

srinjoym commented Mar 24, 2023

This issue has been migrated a new MRTK repository, and the status of this issue will now be tracked at the following location:


Bug found during investigation of validating surface magnetism solver.

@srinjoym srinjoym self-assigned this Mar 24, 2023
@srinjoym srinjoym added the Bug label Mar 24, 2023
@srinjoym srinjoym changed the title Validate Surface Magnetism implementation for Solvers Solver Handler always prefers left hand when tracking two interactors Mar 24, 2023
@srinjoym
Copy link
Contributor Author

Validated on MRTK 3 - the core solver seems to be working as expected. The only issue was in the Solver Handler script - if it is set to track both hands through two interactors, then it will always prefer the left hand even if it's not currently tracked. This probably needs to be fixed as I would expect the solver to start tracking the right hand if the left goes out of view

Here's a video of the current state:

20230324_135257_HoloLens.mp4

@srinjoym srinjoym added the Blocking Blocking development (customer facing) label Mar 24, 2023
@AMollis AMollis added this to the MRTK v3.0 GA milestone Mar 27, 2023
@AMollis
Copy link
Member

AMollis commented Mar 27, 2023

@srinjoym , this seems like a duplicate of this #11398 can you please confirm?

@AMollis AMollis removed the Blocking Blocking development (customer facing) label Mar 27, 2023
@AMollis
Copy link
Member

AMollis commented Mar 27, 2023

Removing "blocking" until we verify there is no workaround for this issue. Suspected workaround:

  • Add two solver handlers to object. One for left hand, one for right hand.

@AMollis AMollis added the MRTK3 label Mar 27, 2023
@srinjoym
Copy link
Contributor Author

srinjoym commented Mar 29, 2023

@AMollis This workaround doesn't work for me. Even with two solver handlers (one for left one for right) the object only follows the left hand. Suggests this is a separate problem from the other issue

Update: Looked into this further and the difference between the two issues is that I'm observing the issue with two interactors (far rays) vs. Matt's issue is observing the issue tracking two hand joints. I think we can make a fix for this specific issue without the upgrade to XRI 2.3 and I'm drafting a PR right now

@srinjoym srinjoym changed the title Solver Handler always prefers left hand when tracking two interactors Solver Handler not switching hands when tracking both left and right *Interactors* Mar 29, 2023
@srinjoym srinjoym changed the title Solver Handler not switching hands when tracking both left and right *Interactors* Solver Handler not switching hands when tracking both left and right **Interactors** Mar 29, 2023
@srinjoym srinjoym changed the title Solver Handler not switching hands when tracking both left and right **Interactors** Solver Handler not switching hands when tracking both left and right Interactors Mar 29, 2023
@AMollis AMollis reopened this May 4, 2023
@AMollis AMollis closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants