Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error throwing on Unity 2017.1.2f1 #1354

Closed
eluchsinger opened this issue Nov 13, 2017 · 3 comments
Closed

Error throwing on Unity 2017.1.2f1 #1354

eluchsinger opened this issue Nov 13, 2017 · 3 comments

Comments

@eluchsinger
Copy link

eluchsinger commented Nov 13, 2017

Overview

Backwards compatibility missing.

The missing method is to know if it's a HoloLens device or a VR device. The simplest fix (although with maybe unintended consequences) would be to wrap it in an #if. But if MR is supported after 2017.2, this could be a viable way to do it.

Expected Behavior

There should be no errors after opening the project.

Actual Behavior

The following error appears:

Assets/HoloToolkit-Examples/UX/Scripts/OptimizeSceneforDeviceType.cs(8,19): error CS0234: The type or namespace name 'XR' does not exist in the namespace 'UnityEngine'. Are you missing an assembly reference?

Steps to reproduce

Open the MixedRealityToolkit-Unity in Unity right after cloning the repo.

Unity Editor Version

2017.1.x
5.6x

Mixed Reality Toolkit Release Version

Latest master 29ff159

@samharper94
Copy link

samharper94 commented Nov 13, 2017

I'm using the latest master on 2017.1.2 as well and it's working on my end, have you enabled VR support under player settings?

That example scene is for immersive and holo headsets so I imagine it needs 2017.2 to work, have you tried importing without the examples? In all the HTK scripts, there is an #if statement

@StephenHodgson
Copy link
Contributor

I had originally fixed this in #1309 but that PR was replaced by #1339

@StephenHodgson
Copy link
Contributor

Duplicate of #1304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants