Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality Settings Regression #950

Closed
StephenHodgson opened this issue Sep 9, 2017 · 6 comments
Closed

Quality Settings Regression #950

StephenHodgson opened this issue Sep 9, 2017 · 6 comments

Comments

@StephenHodgson
Copy link
Contributor

The default names for QualitySettings Levels have been changed in Unity 2017.1.0f3.

Graphics: The default names for Graphics Quality Levels have been changed to be a little clearer, and more in line with what is common across other games. This will only affect newly created projects; existing projects will have the same Quality Level names as before (though, as always, you can edit the names via Edit -> Project Settings -> Quality).

This affects the Project Setup Window for the toolkit, when it sets the quality settings for you.

The code attempts to do a string comparison and we need a new way to calculate the lowest settings.

@jessemcculloch
Copy link

There is a further issue with the Dev_Unity_2017.2 branch, in where the MixedRealityCamera does some setting of these levels for you. However they are using a deprecated enum that has these values hardcoded

@StephenHodgson
Copy link
Contributor Author

Yeah I've already fixed it in my private branch of 2017.2

@jessemcculloch
Copy link

How?

@StephenHodgson
Copy link
Contributor Author

I'll probably submit a PR for it soon

@genereddick
Copy link

So, is the new "Very Low" setting the one we should use?

@StephenHodgson
Copy link
Contributor Author

Check out my PR. It iterates and decreases the level each time it finds a new setting, then sets the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants