Add Grumpkin cycle implementation #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardoalt
reviewed
Jun 10, 2023
huitseeker
force-pushed
the
nova_on_grumpkin
branch
from
6482aee
to
1558991
Compare
- Extend existing tests with additional test cases using the new curve types
- Swap scalar orders between grumpkin and bn256 in `impl_traits!` implementation
- Enhances test coverage for `pasta_curves` and `halo2curves` - Cleans up commented code in `test_ivc_nontrivial` and `test_ivc_nontrivial_with_compression` tests - Updates relevant test cases in `src/lib.rs` to include new curve tests
- Implement the `from_label_serial` function in bn254_grumpkin provider - Add a test to compare parallel and serial implementations of `from_label` function
- Updated the `halo2curves` dependency in `Cargo.toml` to the latest version `0.1.0` from a specific git branch.
huitseeker
force-pushed
the
nova_on_grumpkin
branch
from
1558991
to
43193fc
Compare
huitseeker
changed the title
huitseeker
force-pushed
the
nova_on_grumpkin
branch
2 times, most recently
from
bd78bf4
to
a74e4da
Compare
- Updated bn256_grumpkin.rs to use the cpu_best_multiexp function from pasta provider instead of its native function. - Modified visibility of cpu_best_multiexp function in pasta.rs from private to crate level.
huitseeker
force-pushed
the
nova_on_grumpkin
branch
from
a74e4da
to
182091d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is joint work with @leonardoalt !
This PR pulls in an implementation of, and runs all Nova tests on the Ethereum-friendly Grumpkin curve cycle.
The implementation
iswas from the halo2curves repo with the following pending PR thrown in:privacy-scaling-explorations/halo2curves#47 -
I'll update the present PR when that resolves.