-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support golang
version 1.20
#1988
Comments
Hey Josh! I've added this item to our board. By any chance do you know how soon the Codespace team will need this? This will help us prioritize the item. Thanks! |
Hey William! This would be nice to have as soon as possible. The reasoning is that in our large, default image for Codespaces (which includes both oryx and go) can't fit >1 version of each language, and we prefer to include the latest/LTS versions of tools instead of outdated ones. This makes the oryx/go scenario a less-than-great experience |
Hello, is this still on the board? If so, when will this be implemented? Asking mostly for Go 1.22 |
Thanks for following up! Either @samruddhikhandale or @VincentDondain are the best people to ask about this now |
Maybe I can help? Where would I start to make a pull request? I see that we've got to make a hash for the new versions at https://github.com/microsoft/Oryx/tree/main/platforms/golang/versions , each of these folders has a versionstobuild.txt that needs to be updated It looks like: https://github.com/microsoft/Oryx/blob/main/platforms/golang/getGolangSdk.sh is the main downloading script. Heres what I think is happening:
Seems like it would be an easy fix - but I don't have the ability to test this. Can someone tell me if my logic is right? |
he hashes can be found here: https://go.dev/dl/ using the linux-amd64.tar.gz package. I think I can implement this, doing something similar to this: ae3b0e7 |
#2490 pull request open. Like discussed earlier, I pretty much followed: ae3b0e7 Im not sure if I did the correct thing with full.dockerfile, someone pls test Going off of: https://hub.docker.com/_/golang it looks like all docker versions (even up to the recent 1.23) seems to be supported. Id like someone to look at my pull and verify it. What timeframe should I expect yall to test, check, approve and merge? |
Oryx build currently errors out when the only available installation of go is 1.20. From the Codespaces team, this means publishing our base image with an out-of-date version of go.
Logs
cc/ @samruddhikhandale
The text was updated successfully, but these errors were encountered: