Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Run-Plugin] [Unit Converter] Add LocProject.json to UnitConverter plugin #11665

Closed
mykhailopylyp opened this issue Jun 8, 2021 · 7 comments
Closed

[Run-Plugin] [Unit Converter] Add LocProject.json to UnitConverter plugin #11665

mykhailopylyp opened this issue Jun 8, 2021 · 7 comments
Assignees
@stefansjfw
Labels
Area-Localization issues regarding to Localization the application Priority-1 Bug that is high priority Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete. Run-Plugin Things that relate with PowerToys Run's plugin interface

Comments

@mykhailopylyp
Copy link
Contributor

mykhailopylyp commented Jun 8, 2021 •
edited
Loading

Provide a description of the new feature / enhancement

  • Add LocProject.json to UnitConverter plugin after localization team added translations
  • Update the installer
@mykhailopylyp mykhailopylyp added the Run-Plugin Things that relate with PowerToys Run's plugin interface label Jun 8, 2021
@mykhailopylyp mykhailopylyp self-assigned this Jun 8, 2021
@mykhailopylyp mykhailopylyp mentioned this issue Jun 8, 2021
Merged
10 tasks
@htcfreek
Copy link
Collaborator

htcfreek commented Jun 9, 2021

@mykhailopylyp
Please update the title to include [UnitConverter Plugin].

@mykhailopylyp mykhailopylyp changed the title [Run-Plugin] Add LocProject.json to UnitConverter plugin [Run-Plugin] [Unit Converter] Add LocProject.json to UnitConverter plugin Jun 10, 2021
@dedavis6797
Copy link
Contributor

What's still needed here?

cc @jaimecbernardo

@dedavis6797 dedavis6797 added the Area-Localization issues regarding to Localization the application label Aug 6, 2021
@jaimecbernardo
Copy link
Collaborator

Hi @dedavis6797 ,
I see no loc folder in https://github.com/microsoft/PowerToys/tree/master/src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.UnitConverter
I think the localization team still has to pick this up.

@dedavis6797 dedavis6797 mentioned this issue Aug 9, 2021
Closed
@htcfreek
Copy link
Collaborator

htcfreek commented Sep 10, 2021 •
edited
Loading

Hi @dedavis6797 ,
I see no loc folder in https://github.com/microsoft/PowerToys/tree/master/src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.UnitConverter
I think the localization team still has to pick this up.

These folder is missing because there is no LocProject.json. Or did I misunderstand the devdocs?

And btw. we can only translate nane, description and context menu name.

@dedavis6797
Copy link
Contributor

@htcfreek is correct I believe. Once we create the LocProject.json and Resources.resx files in this folder the loc team will be able to pick it up.

@crutkas crutkas added the Priority-1 Bug that is high priority label Nov 18, 2021
@stefansjfw stefansjfw self-assigned this Dec 24, 2021
@stefansjfw stefansjfw added the Status-In progress This issue or work-item is under development label Dec 24, 2021
@htcfreek htcfreek mentioned this issue Dec 24, 2021
Closed
10 tasks
@Jay-o-Way
Copy link
Collaborator

This is superseded by #15242.
Closing it out -- let me know if that's not right :)

What @DHowett said

@franky920920 franky920920 removed the Status-In progress This issue or work-item is under development label Jan 4, 2022
@franky920920
Copy link
Contributor

(might want to set status in 0.53 project?)

@crutkas

@Jay-o-Way Jay-o-Way added Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete. and removed Resolution-Won't fix labels Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefansjfw stefansjfw

Labels
Area-Localization issues regarding to Localization the application Priority-1 Bug that is high priority Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete. Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@crutkas @franky920920 @mykhailopylyp @jaimecbernardo @stefansjfw @dedavis6797 @htcfreek @Jay-o-Way