Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevDocs] Improve documentation for hwnd_cache #1187

Closed
enricogior opened this issue Jan 30, 2020 · 1 comment
Closed

[DevDocs] Improve documentation for hwnd_cache #1187

enricogior opened this issue Jan 30, 2020 · 1 comment
Assignees
Labels
Issue-Docs Documentation issue that needs to be improved

Comments

@enricogior
Copy link
Contributor

We need to improve the documentation for
https://github.com/microsoft/PowerToys/blob/master/src/common/hwnd_data_cache.h
and
https://github.com/microsoft/PowerToys/blob/master/src/common/hwnd_data_cache.cpp

Also consider renaming some methods:
get_window_and_path -> this function filters out the current window and if not filtered, it returns the ancestor window handle and path

get_window -> this function is identical to get_window_and_path but returns only the ancestor handle

@enricogior enricogior added the Issue-Docs Documentation issue that needs to be improved label Jan 30, 2020
@bzoz
Copy link
Contributor

bzoz commented Feb 7, 2020

hwnd_data_cahce was removed, so this is obsolete

@bzoz bzoz closed this as completed Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Docs Documentation issue that needs to be improved
Projects
None yet
Development

No branches or pull requests

2 participants