Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msix] installer needs to be signed. #1382

Closed
crutkas opened this issue Feb 27, 2020 · 4 comments
Closed

[msix] installer needs to be signed. #1382

crutkas opened this issue Feb 27, 2020 · 4 comments
Labels
Area-Setup/Install Refers to installation mechanism Priority-0 Bugs that we consider release-blocking/recall-class (P0) Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@crutkas
Copy link
Member

crutkas commented Feb 27, 2020

Build 0.15 off the build server wasn’t signed.
@crutkas crutkas added Area-Setup/Install Refers to installation mechanism Priority-0 Bugs that we consider release-blocking/recall-class (P0) Severity-Blocking labels Feb 27, 2020
@crutkas
Copy link
Member Author

crutkas commented Feb 27, 2020

Does the bundle need to be signed too?

@enricogior
Copy link
Contributor

Yes, it does.
For some reason, the signing didn't happen even if it is specified in the yml file:

PowerToys/.pipelines/pipeline.user.windows.yml

Lines 69 to 75 in 5c708b4

- from: '.pipelines\msix\bin'
to: 'Build_MSIX_Package_Output'
include:
- '*.msix'
- '*.msixbundle'
signing_options:
sign_inline: true

This was referenced Feb 27, 2020
Merged
Closed
Merged
Merged
Merged
@crutkas crutkas added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Feb 28, 2020
@crutkas
Copy link
Member Author

crutkas commented Feb 28, 2020

fixed via #1398

@enricogior
Copy link
Contributor

Fix available in 0.15.0 https://github.com/microsoft/PowerToys/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Setup/Install Refers to installation mechanism Priority-0 Bugs that we consider release-blocking/recall-class (P0) Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crutkas @enricogior