Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FZ Editor] Consider using JsonSerializer #1500

Closed
enricogior opened this issue Mar 8, 2020 · 4 comments
Closed

[FZ Editor] Consider using JsonSerializer #1500

enricogior opened this issue Mar 8, 2020 · 4 comments
Labels
Area-Quality Stability, Performance, Etc. FancyZones-Editor Issue revolving the FancyZone Editor Help Wanted We encourage anyone to jump in on these and submit a PR. Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete.

Comments

@enricogior
Copy link
Contributor

FZ engine and FZ editor use temp files to exchange data in json format.
Consider using JsonSerializer for the C# code and investigate what is available in C++ for automatic object serialization to json file.

JsonSerializer requires .NET Core 3.x, so this work-item depends on #776

@enricogior enricogior added FancyZones-Editor Issue revolving the FancyZone Editor Product-FancyZones Refers to the FancyZones PowerToy Area-Quality Stability, Performance, Etc. labels Mar 8, 2020
@crutkas crutkas added this to the v1.0 Release milestone Mar 9, 2020
@crutkas
Copy link
Member

crutkas commented Mar 9, 2020

my feedback boils down to two items:

  1. Feels odd we are writing directly versus serializing an object
  2. regardless of implementation is single spot for serializing / deseralizing. (C++ vs C#)

@enricogior
Copy link
Contributor Author

We should also consider what we can use on ARM, and in case simply drop the use of temp files towards a more robust IPC approach.

@enricogior enricogior removed the Product-FancyZones Refers to the FancyZones PowerToy label May 24, 2020
@enricogior enricogior changed the title Consider using JsonSerializer in FZ editor [FZ Editor] Consider using JsonSerializer May 24, 2020
@crutkas crutkas added the Help Wanted We encourage anyone to jump in on these and submit a PR. label Dec 3, 2020
@crutkas
Copy link
Member

crutkas commented Dec 3, 2020

I think this is part of .net core 3 upgrade as well as migrating to System.Text.Json.

@enricogior
Copy link
Contributor Author

This has been done.

@enricogior enricogior added the Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete. label Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Quality Stability, Performance, Etc. FancyZones-Editor Issue revolving the FancyZone Editor Help Wanted We encourage anyone to jump in on these and submit a PR. Resolution-Already Fixed/Doesn't Apply A change in the product has made the issue obsolete.
Projects
Status: ⚠️Needs Walkthrough
Development

No branches or pull requests

2 participants