Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings theme gets saved before applying and remains until current PowerToys window is closed #1631

Closed
arjunbalgovind opened this issue Mar 18, 2020 · 2 comments
Labels
Product-Settings The standalone PowerToys Settings application

Comments

@arjunbalgovind
Copy link
Contributor

arjunbalgovind commented Mar 18, 2020

Steps to reproduce

  • Open PowerToys settings and change the Settings color to Dark.
  • Switch to another settings page (example FancyZones) and click discard the changes when prompted.

Expected behavior

After discarding the settings color should revert to whatever it was originally.

Actual behavior

The settings page remains in Dark until the window is closed and then reopened or the setting is changed. The actual saved setting in General settings remains as the original setting throughout this.

Screenshots

settings_theme

@enricogior
Copy link
Contributor

Hi @arjunbalgovind
we will fix this in Settings v2.

@crutkas crutkas added the Product-Settings The standalone PowerToys Settings application label Mar 19, 2020
@crutkas
Copy link
Member

crutkas commented Mar 19, 2020

Lets close this out for Settings v2, which is #889

@crutkas crutkas closed this as completed Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Settings The standalone PowerToys Settings application
Projects
None yet
Development

No branches or pull requests

3 participants