-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PowerToys Run] Inline calculations fail when including parentheses -- utilising operator precedence #18490
Comments
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Hi @jcphua |
Nice. Wasn't aware of the My response to this new knowledge, and whether to deem this issue (closed) is whether as per your comment it's a bug or by design-- is PowerToys is targeted for simpletons like me, or for power users (or those attentive enough to have seen any docs mentioning this |
Default activation commands are documented here: https://docs.microsoft.com/en-us/windows/powertoys/run#direct-activation-commands and can be customized in the plugin manager. Let's keep this opened: I will look at source code and clarify this behavior. |
Oh thats pretty simple: @jaimecbernardo @crutkas is this something we want to change? |
I think we should change the default key. One issue we do face is period for math as well. I think ( is too math centric so we should tweak that. Maybe a warning box for “this action command will impact math calculations” for period and ( |
@crutkas |
Program I think is hard as period is pretty powerful in the context of quickness. For date time, It could be as easy as shifting to ) |
Let's not do that 🤣🤣💩 crutkas edited his own quote oops |
Eek. Let edit that |
I looked at the keyboard but there is no other character at this position which we can use. The
Had to look twice to see the difference between the old ( and your suggested ) 😄 |
What does "Eek" mean? Don't know this phrase. |
@crutkas Dou you have an idea for @niels9001 |
I don’t have a massive preference on this. Could be a more complex activation as well such as ‘time’ |
@crutkas After some investigation we should war on the following character as they break calc on global queries: |
Period was picked cause it was a no-shift key in pretty much all (if not all) keyboard layouts. It also has advantage of being east reach where on US keyboards, asterisk fails both those criteria |
Why are we messing with program here? Why don’t we just make the activate “time”? |
I think the period is changed in case somebody wants to start a calculation with (e.g.) |
This comes from you. You suggested to change program plugin.
And yes this is true. |
While valid, That should be done outside this targeted issue and the PR. That is a much larger discussion and thinking point due to two years of muscle memory for everyone and have very few complaints of the scenario. |
@crutkas |
this targeted that since keyword so yes. I do think we should rethink what is on by default. |
Description of the new feature / enhancement
I expect operator precedence (use of parentheses) for inline calculations should at the least be supported by PowerToys Run.
Currently when attempting to perform non-complex calculations involving parentheses, the input stops being treated as a calculation.
For comparison, macOS equivalent Spotlight supports parentheses without issue.
Scenario when this would be used?
Useful when trying to perform only slightly more complex calculations using PowerToys Run.
Supporting information
Simple inputs such as:
(25+20)
(1+2)/3
The text was updated successfully, but these errors were encountered: