Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New powertoys should be enabled by default #1878

Closed
crutkas opened this issue Apr 2, 2020 · 6 comments
Closed

New powertoys should be enabled by default #1878

crutkas opened this issue Apr 2, 2020 · 6 comments
Labels
Area-Quality Stability, Performance, Etc. Area-Setup/Install Refers to installation mechanism Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@crutkas
Copy link
Member

crutkas commented Apr 2, 2020

we may have fixed this for Preview pane but sounds like new utilities for existing users are disabled by default.

The behavior should be on by default.

OOBE once that is operational will alert users on upgrades of new features and functionality.
@crutkas crutkas added Product-Settings The standalone PowerToys Settings application Area-Setup/Install Refers to installation mechanism Area-Quality Stability, Performance, Etc. labels Apr 2, 2020
@crutkas
Copy link
Member Author

crutkas commented Apr 2, 2020

Window Walker was the PT that made me aware of this issue

@enricogior
Copy link
Contributor

Found the bug. On a clean machine all modules will be on by default.
When upgrading, new modules may be off because of this reverse logic:

https://github.com/microsoft/PowerToys/blob/master/src/runner/general_settings.cpp#L209-L221

We should turn off only the modules that are explicitly off, instead of not turning on those that are not explicitly on.

@enricogior
Copy link
Contributor

@crutkas
should we fix it for 0.16.1?

@crutkas
Copy link
Member Author

crutkas commented Apr 2, 2020

I would like this corrected if possible for 0.16.1

@yevhenii44-zz yevhenii44-zz mentioned this issue Apr 2, 2020
Merged
1 task
@enricogior enricogior added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 6, 2020
@enricogior
Copy link
Contributor

Fixed for 0.16.1

@enricogior
Copy link
Contributor

Fix available in 0.16.1 https://github.com/microsoft/PowerToys/releases

@Itchibon777 Itchibon777 mentioned this issue Apr 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Quality Stability, Performance, Etc. Area-Setup/Install Refers to installation mechanism Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crutkas @enricogior