Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run Dev] Nuget package not being included? #21752

Closed
lin-ycv opened this issue Nov 4, 2022 · 4 comments
Closed

[Run Dev] Nuget package not being included? #21752

lin-ycv opened this issue Nov 4, 2022 · 4 comments
Labels
Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams

Comments

@lin-ycv
Copy link

lin-ycv commented Nov 4, 2022

Microsoft PowerToys version

0.64.0

Installation method

GitHub

Running as admin

No response

Area(s) with issue?

PowerToys Run

Steps to reproduce

In my plugin for Run I want to start using the Octokit nuget package
but for some reason when I build (Ctrl+B) the plugin, Octokit.dll isn't being included
even if I manually add the dll file to the program files folder, I get an initialization error saying my plugin can't find the dll
image

Anyone know what I'm doing wrong?

✔️ Expected Behavior

nuget packages to be included

❌ Actual Behavior

nuget package not being included

Other Software

EverythingPowerToys

@lin-ycv lin-ycv added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Nov 4, 2022
@lin-ycv lin-ycv changed the title Nuget package not being included? [Run Dev] Nuget package not being included? Nov 4, 2022
@TheOjasSingh
Copy link

Can you assign this to me

@htcfreek
Copy link
Collaborator

htcfreek commented Nov 5, 2022

Hey guys is your problem relatet to the issue #18435 and PR #18437?

cc: @stefansjfw , @rozbo

@ohroy
Copy link

ohroy commented Nov 5, 2022

Ok, cause some reason, power toys now do NOT load 3rd dll

@lin-ycv
Copy link
Author

lin-ycv commented Nov 5, 2022

Welp, it is related to PR #18437
I see that there's still some issues to iron out before it's merged.
I guess I'll switch dllimport as a temp fix, looking forward to the PR being merged.

@lin-ycv lin-ycv closed this as completed Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams
Projects
None yet
Development

No branches or pull requests

4 participants