Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: CLI/API integration for Peek #26422

Open
yaira2 opened this issue May 28, 2023 · 8 comments
Open

Feature: CLI/API integration for Peek #26422

yaira2 opened this issue May 28, 2023 · 8 comments
Labels
Area-App Compat Issues revolving around application compatibility across PowerToys Area-Build Issues pertaining to the build system, CI, infrastructure, meta Idea-Enhancement New feature or request on an existing product Product-Peek Refers to Peek Powertoys

Comments

@yaira2
Copy link

yaira2 commented May 28, 2023

Description of the new feature / enhancement

Congratulations on the new Peek feature! This adds a popular functionality that until now required the use of third-party apps. Files (https://github.com/files-community/Files) already has support for QuickLook, but we'd like to add support for PowerToys Peek files-community/Files#12432 in order to provide users with more choices.

Scenario when this would be used?

We're ready to add support for PowerToys Peek in Files whenever an API is available, in fact, we've already completed the preparation work and we're looking forward to this integration. In addition to Files, there are a couple of other third-party file managers that can also benefit from an API.

Supporting information

Feature request on the Files repo: files-community/Files#12432

@yaira2 yaira2 added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label May 28, 2023
@crutkas
Copy link
Member

crutkas commented May 28, 2023

What would you expect here. Can you explain how you’d expect to interact with peek

@yaira2
Copy link
Author

yaira2 commented May 28, 2023

We can add/remove more interaction methods depending on the provider, but the most common interactions are
Space to toggle preview (users can remap the shortcut)
Arrow keys to switch between files (this interaction is only used when the preview provider doesn't have built-in support)

@yaira2
Copy link
Author

yaira2 commented May 28, 2023

The implementation details of the API aren't very important, the main requirement is that applications can pass a file path to PowerToys and that it'll handle everything from there.

@zhuxb711
Copy link

zhuxb711 commented May 29, 2023

I think Named Pipe or COM interface should be the better way to achieve the function.

How the other application achieve those functions?

"Seer" use window message COPY_DATA and "Quicklook" use Named Pipe to interact with other application.

Five API is needed for a preview application:

  1. Check if Peek is available and running currently
  2. Check if Peek's window is presents
  3. Toggle Peek (Show its window if not present, or switch to new file if window is present)
  4. Switch Peek (Switch to new file if window is present, don't do anything if window is not present)
  5. Close the window of Peek (Only works if Peek's window is present)

@Jay-o-Way Jay-o-Way added Idea-Enhancement New feature or request on an existing product Area-Build Issues pertaining to the build system, CI, infrastructure, meta Area-App Compat Issues revolving around application compatibility across PowerToys Product-Peek Refers to Peek Powertoys and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels May 29, 2023
@crutkas crutkas changed the title Feature: API integration for Peek Feature: CLI/API integration for Peek Jun 9, 2023
@yaira2
Copy link
Author

yaira2 commented Aug 1, 2023

We keep getting requests for this integration in Files. In the meantime I've been recommending QuickLook and SeerPro but it would be great to offer support for PowerToys Peek as well.

@Likqez
Copy link

Likqez commented Aug 12, 2023

Any updates on this?

@pa-0
Copy link

pa-0 commented Mar 26, 2024

Also just to add if this hasn't been covered, this would possibly give us a path to activating Peek windows from the Everything Search results (desktop app). Just a thought.

@yaira2
Copy link
Author

yaira2 commented May 9, 2024

@crutkas I understand the PowerToys team was exploring different approaches for this API. Are there any updates that you can share?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-App Compat Issues revolving around application compatibility across PowerToys Area-Build Issues pertaining to the build system, CI, infrastructure, meta Idea-Enhancement New feature or request on an existing product Product-Peek Refers to Peek Powertoys
Projects
Status: No status
Development

No branches or pull requests

6 participants