Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Launcher] launcher isn't prioritizing *exact match* #3128

Closed
DHowett opened this issue May 19, 2020 · 8 comments
Closed

[Launcher] launcher isn't prioritizing *exact match* #3128

DHowett opened this issue May 19, 2020 · 8 comments
Assignees
Labels
Hot Fix Items we will product an out-of-band release for Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@DHowett
Copy link
Member

DHowett commented May 19, 2020

Environment

Windows build number: 19041
PowerToys version: 0.18.0
PowerToy module for which you are reporting the bug (if applicable): Launcher

Steps to reproduce

Install Vim/gVim.

Search for gVim in launcher.

Expected behavior

gVim is highlighted:

image

Actual behavior

Help is highlighted, which is in the vim start menu folder.

image

gVim is an exact match for gVim; there is no circumstance under which a user who types gVim wants to launch something other than gVim if gVim exists in the match list.

@DHowett
Copy link
Member Author

DHowett commented May 19, 2020

This is also true of vim:

image

@jyuwono
Copy link
Contributor

jyuwono commented May 19, 2020

Hey @DHowett! Thanks for your feedback! We have an issue to implement exact phrase matching (#2451) which will solve this problem. What do you think about adding "" to look for exact phrase?

@jyuwono jyuwono added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label May 19, 2020
@DHowett
Copy link
Member Author

DHowett commented May 19, 2020

Thanks!

I don't believe that I (as a user) should need to use "" to make it find something whose name is exactly my search term. If we implement search term weighting, and make exact matches weigh more, this problem solves itself without a special syntax!

@t-makaro
Copy link

I just noticed this when looking for cmd. Win+R, then typing "cmd", then Enter opens cmd as expected. With this launcher I end up getting the Anaconda python shell:
image

This alone stops it from being a Win+R replacement.

@crutkas crutkas added this to the v1.0 Release milestone May 19, 2020
@crutkas crutkas added the Hot Fix Items we will product an out-of-band release for label May 19, 2020
@alekhyareddy28
Copy link
Contributor

Thanks!

I don't believe that I (as a user) should need to use "" to make it find something whose name is exactly my search term. If we implement search term weighting, and make exact matches weigh more, this problem solves itself without a special syntax!

Thank you for pointing this out. We're working on it.

@alekhyareddy28
Copy link
Contributor

I just noticed this when looking for cmd. Win+R, then typing "cmd", then Enter opens cmd as expected. With this launcher I end up getting the Anaconda python shell:
image

This alone stops it from being a Win+R replacement.

Thanks for highlighting this. We're working on improving the scoring.

However, I would like to point out that to emulate Win+R, we need to add the > symbol and this
would be directly populated on pressing Win+R, once we enable the override option. Till then, the query would be > cmd and pressing enter would show up the command prompt.

image

@crutkas
Copy link
Member

crutkas commented May 21, 2020

For @t-makaro, that is a diff issue. made it issue #3461

@crutkas crutkas added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label May 21, 2020
@crutkas
Copy link
Member

crutkas commented May 22, 2020

We just released 0.18.1 which will have this fix included in it.

@crutkas crutkas closed this as completed May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hot Fix Items we will product an out-of-band release for Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

5 participants