Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remap shortcuts are flipped #3147

Closed
david-antiteum opened this issue May 19, 2020 · 6 comments
Closed

remap shortcuts are flipped #3147

david-antiteum opened this issue May 19, 2020 · 6 comments
Labels
Hot Fix Items we will product an out-of-band release for Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@david-antiteum
Copy link

Environment

Windows build number: [run "ver" at a command prompt]
PowerToys version: 0.18
PowerToy module for which you are reporting the bug (if applicable): Keyboard Manager

Steps to reproduce

Create a remap, for example, Win + Down -> Win + H (to hide the current window). Original shortcut is Win + Down and the New Shortcut is Win + H. To work, in the UI, this shortcut must be created the other way around to work.

@ArttuLai
Copy link

Yeah I had identical thought the first time I tested this. But try to read it again, carefully. IDK, the ol' brain doing some tricks on me, but I think the UI shows it correctly after all 😃

@saahmedm saahmedm added the Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager label May 19, 2020
@saahmedm
Copy link
Contributor

saahmedm commented May 19, 2020

Did you want to Press Win + H and have that result in Win + Down? Essentially minimizing your window with Win + H? If that's the case, Win + H is your Original Shortcut (the shortcut you want to remap) and Win + Down is the New Shortcut.

Original shortcut is for the shortcut who's result you want to change, and New Shortcut is for what you want that shortcut to invoke.

@david-antiteum
Copy link
Author

david-antiteum commented May 19, 2020

@ArttuLai Aaaaaaall right :) same problem than you.

@saahmedm So the bug is on the labels and not on the code. It is really confusing, the name, the arrow. All implies the opposite of what is programmed.

Ah! In any case, thanks for the tool, super handy!

@saahmedm
Copy link
Contributor

@david-antiteum we figured if Win + Down was the Original shortcut, it would imply that it is being changed. Win + Down is still Win + Down in this case, but Win + H is also Win + Down.

I get the confusion though, we'll monitoring how much of a problem this is and will alter the labels / naming / arrows to be more clear if need be. Thanks David!

@crutkas
Copy link
Member

crutkas commented May 19, 2020

I think we really need to figure out is this a labeling issue or a UX placement issue.

It is funny, i agree that this feels awkward in shortcuts but it feels 'right' for remapping a key.

@saahmedm saahmedm added Issue-Bug Something isn't working and removed Issue-Bug Something isn't working labels May 19, 2020
@saahmedm saahmedm mentioned this issue May 20, 2020
4 tasks
@crutkas crutkas added Hot Fix Items we will product an out-of-band release for Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. labels May 22, 2020
@crutkas crutkas added this to the v1.0 Release milestone May 22, 2020
@crutkas
Copy link
Member

crutkas commented May 22, 2020

We just released 0.18.1 which will have this fix included in it.

@crutkas crutkas closed this as completed May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hot Fix Items we will product an out-of-band release for Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

4 participants