-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peek preview area flickers when jumping to next/previous file #34515
Comments
This is a bugbear of mine, too, so thank you very much for raising it as an issue! The underlying reason is related to the fact that the old previewer is removed and a new one created every time you navigate to a new file, which leads to the window background being shown briefly. It may be that keeping the old previewer around until the new one has finished loading the new file would be a viable solution, but there's some subtlety about how long to wait before showing that Peek has registered your input, so perhaps a new way of showing progress would be needed. I'd like to look at this, but it's a medium-to-large complexity task affecting some fundamentals of how the different previewers are created and managed, so may take a while. |
go for it @daverayment |
@rbtk1
Thank you! |
@daverayment For images its more noticable when flicking through very bright images since it will breifly flash dark (im using dark theme, so might be different reversed with the light OS theme), but i actually started this thread when i preview a whole bunch of folder and Peek unsupported files where it just shows the icon and the metadata, and got a bit annoyed the icon and text flashed every time selecting next/previous. The window resizing im not sure about what i would prefer. As long as the image is not starting scaled down then scaled up afterwards along with the window frame and thereby would again appear to flicker, then i dont think i have a preference. |
@rbtk1 Thanks so much for answering the questions; it's really going to help prioritise the work and give me an idea what's important to test for. I have a fix for the image previewer now, and it's much more pleasant to rapidly move through a folder now. |
Microsoft PowerToys version
0.83.0
Installation method
WinGet
Running as admin
Yes
Area(s) with issue?
Peek
Steps to reproduce
Jumping from one file to the next using he arrow keys with Peek open, the preview area flickers every single time it previews the next file.
This might be considered a minor issue, but it looks quite bad and it reflect badly on the polish of the app.
✔️ Expected Behavior
No flickering when switching between previewed files with the arrow keys
❌ Actual Behavior
The preview area is cleared for a milisec before displaying the next file, making it flicker, especially if you quickly preview a bunch of files after one another.
Other Software
No response
The text was updated successfully, but these errors were encountered: