Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise, GPO] gpo.h: Fixes and code order improvements #35002

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Sep 22, 2024

Summary of the Pull Request

This PR...

  • fixes wrong policies to use the correct method.
  • improves the code order/structure to avoid this mistakes in the future.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@htcfreek htcfreek self-assigned this Sep 22, 2024
@htcfreek htcfreek added Issue-Bug Something isn't working Priority-1 Bug that is high priority Area-Enterprise Issues relevant to large enterprises, SCCM, run as admin restrictions, ... Needs-Review This Pull Request awaits the review of a maintainer. labels Sep 22, 2024

This comment has been minimized.

This comment has been minimized.

@htcfreek htcfreek changed the title [Enterprise, GPO] gpo.h: Fixes and layout improvements [Enterprise, GPO] gpo.h: Fixes and code order improvements Sep 22, 2024
@htcfreek
Copy link
Collaborator Author

htcfreek commented Sep 22, 2024

CI failed because of a hang in CI and not because of a code bug.

@crutkas, please restart pipeline.

@crutkas
Copy link
Member

crutkas commented Sep 22, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@htcfreek
Copy link
Collaborator Author

@crutkas
This should be in for 0.85.0 release. It's an important fix. Is there someone who can review the PR?

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch! Thank you for the fix!

@jaimecbernardo jaimecbernardo merged commit f7932af into microsoft:main Sep 23, 2024
9 checks passed
@htcfreek htcfreek deleted the PT_FixGPOs branch September 23, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Enterprise Issues relevant to large enterprises, SCCM, run as admin restrictions, ... Issue-Bug Something isn't working Needs-Review This Pull Request awaits the review of a maintainer. Priority-1 Bug that is high priority
Projects
Development

Successfully merging this pull request may close these issues.

3 participants