[Run, tracker] calculator (mage nuget) having calculation issues

[Jay-o-Way]

Environment

PowerToys version: 0.18.1
PowerToy module for which you are reporting the bug (if applicable): Power Run

Example 1 : digits after the decimal point

Example: type "123 * 4.56"
Result = 560,8800000000001

Probably an an issue with the signing of the number, since the total amount of digits is 16, or converting binary to decimal. When using one negative number, the result = -560,8800000000001.

Example 2 : no operator

Example: type "123 456"
Result = 56088

No operator is used here. I know that multliplication may be implied between numbers and constants, or between numbers and (other things in) brackets, but not between numbers only. Also, spaces may sometimes be used in big numbers as thousands separators.

Suggestion: Spaces between only numbers should be ignored (like treated as thousands separators). Unless somebody else has a better idea?

[RWeigelt]

Maybe the math code of the open-sourced Windows Calculator could be a good fit here, because it has solved problems like in example 1. It is written in C++, though, and I don't know how much work would be required for using it outside calc.exe.

[Jay-o-Way]

This is probably gonna sound like a rookie comment, but using open source Windows code that is already out there, sounds pretty obvious to me. Re-inventing things that already have been made in/for a similar situation sounds like a lot of "wasted" time and energy? 🤓

[jyuwono]

Related to #3488 and #2265

[VisibleReality]

One interesting thing I noticed is that example 1 doesn't happen with more complex calculations (maybe when brackets are involved?)

[mkielar]

I gets weird even for simple additions.

[androidSwDev099]

Simple examples to demonstrate.

More strangeness when entered 39.9 .... why is it proposing a different number?

39.9 + 1

[crutkas]

xref #3764

[crutkas]

in calculator plugin, Mages looks like it is doing some type of odd casting.

Works

• 2+2.1
• 2+2.1111

Incorrect

• 2+2.11
• 2+2.111

var result = MagesEngine.Interpret(query.Search); is what does the calc.

[crutkas]

This should be resolved in our 0.21.1 release of PowerToys. https://github.com/microsoft/PowerToys/releases/tag/v0.21.1 to download it.