Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run][New Plugin] Windows Terminal: show "profiles" as entries in results #4194

Closed
trajano opened this issue Jun 8, 2020 · 9 comments
Closed
Assignees
Labels
Idea-Enhancement New feature or request on an existing product Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Things that relate with PowerToys Run's plugin interface

Comments

@trajano
Copy link

trajano commented Jun 8, 2020

Summary of the new feature/enhancement

Detect Windows Terminal is set up and add the "profiles" as entries in Powershell Run.

So if I type in "Windows Powershell" it would show as an option to open up the profile in Windows Terminal.

Proposed technical implementation details (optional)

@saahmedm saahmedm added Idea-Enhancement New feature or request on an existing product and removed Idea-Enhancement New feature or request on an existing product labels Jun 8, 2020
@saahmedm
Copy link
Contributor

saahmedm commented Jun 8, 2020

@trajano can you clarify? not 100% familiar with WT profiles

@saahmedm saahmedm added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-PowerToys Run Improved app launch PT Run (Win+R) Window labels Jun 8, 2020
@trajano
Copy link
Author

trajano commented Jun 9, 2020

Here is the documentation for it https://docs.microsoft.com/en-us/windows/terminal/customize-settings/profile-settings#dropdown-settings

Specifically I think what we are looking for is "name", the UUID mapping and the icon.

@crutkas crutkas added Idea-Enhancement New feature or request on an existing product and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 19, 2020
@crutkas crutkas added this to the Suggested Ideas milestone Jun 19, 2020
@crutkas
Copy link
Member

crutkas commented Jun 19, 2020

So i sync'ed with Terminal. and we think this is a great idea. I think there are a few things that would need to do.

  1. Create a plugin for terminal that some how extends / tweaks the search results.
  2. tweak how plugins interact with final results to enable this 'enhancement' style query
  3. figure out a way to get the profile data from Terminal itself. Maybe via an extension point.

@DHowett for vis.

@enricogior enricogior changed the title Detect Windows Terminal is set up and add the "profiles" as entries in Powershell Run [Run] Detect Windows Terminal is set up and add the "profiles" as entries in results Jan 9, 2021
@enricogior enricogior added the Run-Plugin Things that relate with PowerToys Run's plugin interface label Feb 27, 2021
@enricogior enricogior changed the title [Run] Detect Windows Terminal is set up and add the "profiles" as entries in results [Run][New Plugin] Windows Terminal: show "profiles" as entries in results Feb 27, 2021
@davidegiacometti
Copy link
Collaborator

A few months ago I started a POC that is left abandoned for query Terminal profiles in PowerToys Run.
It support both Terminal and Terminal Preview and it's based on settings.json file.

Terminal Plugin

@davidegiacometti
Copy link
Collaborator

@crutkas any thought on my previous post? I can review and cleanup the code and create a draft PR if we are fine with retrieving terminal profiles from settings JSON. This could be replaced with another implementation in future.

CC @DHowett

@crutkas
Copy link
Member

crutkas commented Sep 21, 2021

I sycn'ed with a few people, sweet. Great idea!

@Aaron-Junker Aaron-Junker added the Status-In progress This issue or work-item is under development label Sep 24, 2021
@Aaron-Junker
Copy link
Collaborator

@davidegiacometti I know I said that many times, but I will say it hundred times more, if you don't do it: Add the In progress label and assign yourself to an issue if you start working on the issue. Please just do it. This help maintaining this repository. And if you don't want to, just write something like:

@Aaron-Junker I'm now working on this

and you're good to go. (You can even add this as a saved reply if you want).

I know you said that here and it should have been added before here, but it's not just about this issue.

I really appreciate your contributions, but this is just a little detail you have to do, please.

@davidegiacometti
Copy link
Collaborator

A Terminal profile icon could be a resource inside Terminal package or an image file.
Since retrieve icons from the package could be tricky, for the sake of simplicity I would use plugin icon or Terminal icon.

Let's vote:

  • Plugin icon: 🎉
  • Terminal icon: 🚀

Plugin icon

Screenshot 2021-09-26 120058
Screenshot 2021-09-26 120034

Terminal icon

Screenshot 2021-09-26 115802
Screenshot 2021-09-26 115835

@davidegiacometti davidegiacometti added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Oct 7, 2021
@dedavis6797
Copy link
Contributor

Resolved with v0.49.0. Thanks @davidegiacometti!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea-Enhancement New feature or request on an existing product Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
None yet
Development

No branches or pull requests

7 participants