Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test "core" headers #1411

Closed
StephanTLavavej opened this issue Oct 29, 2020 · 0 comments · Fixed by #1405
Closed

Test "core" headers #1411

StephanTLavavej opened this issue Oct 29, 2020 · 0 comments · Fixed by #1405
Assignees
Labels
fixed Something works now, yay! test Related to test code

Comments

@StephanTLavavej
Copy link
Member

See: https://github.com/microsoft/STL/wiki/The-Difference-Between-Core-And-Non-Core-Headers

During the development of #1370, I damaged the "core" header <type_traits> by including <cstdint> (which we found just before merging). I didn't even check <cstdint> because it was "obviously safe" - it just includes <stdint.h> and has using-declarations for typedefs. However, it was also including <yvals.h> (having predated the "core"/"non-core" split), which contains the STL's #pragma detect_mismatch directives:

#include <yvals.h>

We should have a test that includes all of the headers we expect to be "core", and verifies that they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Something works now, yay! test Related to test code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant