Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LWG-3211 std::tuple<> should be trivially constructible #1459

Closed
futuarmo opened this issue Nov 12, 2020 · 2 comments · Fixed by #1460
Closed

LWG-3211 std::tuple<> should be trivially constructible #1459

futuarmo opened this issue Nov 12, 2020 · 2 comments · Fixed by #1460
Labels
fixed Something works now, yay! LWG Library Working Group issue

Comments

@futuarmo
Copy link
Contributor

LWG-3211 std::tuple<> should be trivially constructible
@futuarmo futuarmo mentioned this issue Nov 12, 2020
Merged
@miscco
Copy link
Contributor

miscco commented Nov 12, 2020

Has this ABI implications? Otherwise the fix is rather trivial (I blame @CaseyCarter for that one)

STL/stl/inc/tuple

Lines 207 to 209 in 9959929

constexpr tuple() noexcept /* strengthened */ {}
constexpr tuple(const tuple&) noexcept /* strengthened */ {} // TRANSITION, ABI: should be defaulted

@CaseyCarter CaseyCarter added LWG Library Working Group issue work in progress labels Nov 12, 2020
@StephanTLavavej
Copy link
Member

As the previous ABI-breaker here, I believe that the default ctor should be OK to change, but we'll double-check of course.

@StephanTLavavej StephanTLavavej mentioned this issue Nov 12, 2020
Closed
52 tasks
@StephanTLavavej StephanTLavavej added fixed Something works now, yay! and removed work in progress labels Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed Something works now, yay! LWG Library Working Group issue
Projects
STL LWG Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LWG-3211 std::tuple<> should be trivially constructible futuarmo/STL
4 participants
@CaseyCarter @miscco @StephanTLavavej @futuarmo