Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta LWG issue: 2022-07 meeting #2872

Closed
26 tasks done
frederick-vs-ja opened this issue Jul 18, 2022 · 4 comments
Closed
26 tasks done

Meta LWG issue: 2022-07 meeting #2872

frederick-vs-ja opened this issue Jul 18, 2022 · 4 comments
Labels
LWG Library Working Group issue meta Issues about issues! resolved Successfully resolved without a commit

Comments

@frederick-vs-ja
Copy link
Contributor

frederick-vs-ja commented Jul 18, 2022

(Previous meta-issue: #2527)

At the July 2022 virtual plenary meeting, the resolutions of the following LWG issues were merged into the C++ Working Paper.

❔ Not yet analyzed

❌ Not applicable

If an issue requires no action from implementers, we mark it as N/A. Categories:

  • Pure wording clarifications with nothing to implement (these can be changes to non-normative text like examples and informative notes, or wording cleanups to normative text that don't impact observable behavior)
    • LWG-3659 Consider ATOMIC_FLAG_INIT undeprecation
      • MSVC STL has never deprecated this macro, and it might be impossible to reflect such deprecation in a library implementation
  • Something that increases the restrictions placed on users, but implementers aren't expected to enforce those restrictions.
  • Fixes for obviously broken wording, where implementers would have done the right thing anyways

😸 Already implemented

Sometimes we cite LWG issues in product code comments as we're implementing their proposed resolutions. When the resolutions are officially accepted, we should remove the citations (as the default assumption is that we're implementing what the Standard says). If something is especially subtle, we can convert the citation to mention the relevant Standard section.

Sometimes we should add test coverage - e.g. when the Standard begins requiring something that we were already doing, but weren't explicitly testing for.

  • Already implemented, comments need to be removed and messages need to cite the Standard
    • LWG-3670 Cpp17InputIterators don't have integer-class difference types
    • LWG-3705 Hashability shouldn't depend on basic_string's allocator
  • Implemented without comments
    • LWG-3687expected<cv void, E> move constructor should move
    • LWG-3703 Missing requirements for expected<T, E> requires is_void<T>
    • LWG-3704 LWG-2059 added overloads that might be ill-formed for sets
    • LWG-3708 take_while_view::sentinel's conversion constructor should move

🩹 Patches an unimplemented feature

We should record this LWG issue in the GitHub issue tracking the feature. That way, we'll remember to verify it, but it doesn't represent net new work.

  • LWG-3692 zip_view::iterator's operator<=> is overconstrained
  • LWG-3702 Should zip_transform_view::iterator remove operator<?

🐞 Not yet implemented

@frederick-vs-ja
Copy link
Contributor Author

frederick-vs-ja commented Jul 18, 2022

@StephanTLavavej @CaseyCarter feel free to edit this if my analyzation for any LWG issue is incorrect, P/R for any issue hasn't been voted into the working paper, or the implementation status changes.

@CaseyCarter
Copy link
Member

CaseyCarter commented Jul 19, 2022

Wow, thanks @frederick-vs-ja! This is a ton of work. I'm going to tag this (and any relevant PRs) as "blocked" until we actually get approval for the proposed resolutions in the WG21 virtual plenary on 2022-07-25, but folks should feel free to go ahead and submit/review such PRs. I'm only concerned that we not merge before WG21 approves.

@StephanTLavavej StephanTLavavej added LWG Library Working Group issue meta Issues about issues! labels Jul 19, 2022
@StephanTLavavej
Copy link
Member

Agreed, this is amazing, thank you! 😻 I've applied a small edit, unchecking the "Already implemented, comments need to be removed and messages need to cite the Standard" items (as unchecked boxes mean "action needs to be taken", checked boxes mean "no further action required"), and adding sub-bullets with details about the affected files.

@CaseyCarter
Copy link
Member

I believe every issue has now been processed. We have PRs out for the majority, I've recorded the two that patch zip in #2252, filed issues for the three that don't yet have pull requests, and submitted a PR to cleanup comments for the two we implemented speculatively with comments.

Thanks to everyone, and again extra-special thanks to @frederick-vs-ja for filing this issue and a majority of the resolution PRs.

@CaseyCarter CaseyCarter added the resolved Successfully resolved without a commit label Jul 27, 2022
@StephanTLavavej StephanTLavavej unpinned this issue Jul 27, 2022
@StephanTLavavej StephanTLavavej changed the title July 2022 LWG issues Meta LWG issue: 2022-07 meeting Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LWG Library Working Group issue meta Issues about issues! resolved Successfully resolved without a commit
Projects
Status: Done
Development

No branches or pull requests

3 participants