Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LWG-3823 Unnecessary precondition for is_aggregate #3229

Closed
StephanTLavavej opened this issue Nov 15, 2022 · 2 comments · Fixed by #3231
Closed

LWG-3823 Unnecessary precondition for is_aggregate #3229

StephanTLavavej opened this issue Nov 15, 2022 · 2 comments · Fixed by #3231
Labels
compiler Compiler work involved fixed Something works now, yay! LWG Library Working Group issue

Comments

@StephanTLavavej
Copy link
Member

LWG-3823 Unnecessary precondition for is_aggregate

It appears that we'll need to request an MSVC compiler change for this. I haven't checked Clang and EDG's behavior.
@StephanTLavavej StephanTLavavej added LWG Library Working Group issue compiler Compiler work involved labels Nov 15, 2022
@StephanTLavavej StephanTLavavej mentioned this issue Nov 15, 2022
Closed
58 tasks
@frederick-vs-ja
Copy link
Contributor

I've submitted DevCom-10201896 and LLVM-59002 for this. EDG's __is_aggregate also rejects arrays of incomplete types.

I believe a workaround using disjunction_v is implementable (Godbolt link). Should we temporarily use such a workaround?

@frederick-vs-ja frederick-vs-ja mentioned this issue Nov 15, 2022
Merged
@CaseyCarter
Copy link
Member

I believe a workaround using disjunction_v is implementable (Godbolt link). Should we temporarily use such a workaround?

As evidenced by my approval of your PR, I think the workaround is fine.

@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Nov 18, 2022
@github-project-automation github-project-automation bot moved this to Available in STL LWG Issues Mar 28, 2024
@StephanTLavavej StephanTLavavej moved this from Available to Done in STL LWG Issues Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler Compiler work involved fixed Something works now, yay! LWG Library Working Group issue
Projects
STL LWG Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement LWG-3823 Unnecessary precondition for is_aggregate (workaround) frederick-vs-ja/STL
3 participants
@CaseyCarter @StephanTLavavej @frederick-vs-ja