vector_algorithms.cpp: turn tails

[AlexGuteniev]

There are some scalar tails extracted in vector_algorithms.cpp,
Whereas some are used multiple times, some are used just one. A few examples:

STL/stl/src/vector_algorithms.cpp

Lines 1057 to 1058 in 8674b3d

	return _Minmax_tail<_Mode, typename _Traits::_Signed_t, typename _Traits::_Unsigned_t>(
	_First, _Last, _Res, _Sign, _Cur_min_val, _Cur_max_val);

STL/stl/src/vector_algorithms.cpp

Line 1396 in 8674b3d

return _Find_trivial_tail(_First, _Last, _Val);

STL/stl/src/vector_algorithms.cpp

Line 1345 in 8674b3d

return _Find_trivial_unsized_fallback(_First, _Val);

The tail extraction does not serve any purpose in such cases, it only provides an obstacle for debugging of optimized code (as tails are expectedly inlined. so the debugger does not navigate the lines).

[CaseyCarter]

Checking my understanding: You're suggesting that we should hand-inline tail-called functions with only one callsite?

[AlexGuteniev]

Checking my understanding: You're suggesting that we should hand-inline tail-called functions with only one callsite?

Exactly.

[StephanTLavavej]

We talked about this at the weekly maintainer meeting and are highly in favor of such fusion/hand-inlining, as a stylistic preference.