Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSO_0226079_mutex is sporadically failing #1472

Closed
StephanTLavavej opened this issue Nov 13, 2020 · 1 comment · Fixed by #4973
Closed

VSO_0226079_mutex is sporadically failing #1472

StephanTLavavej opened this issue Nov 13, 2020 · 1 comment · Fixed by #4973
Labels
fixed Something works now, yay! test Related to test code

Comments

@StephanTLavavej
Copy link
Member

We encountered a sporadic test failure:

Assertion failed: time_execution([this] { unique_lock<Mutex> ul(mtx, 50ms); assert(!ul.owns_lock()); }) >= 50ms,
file C:\a\1\s\tests\std\tests\VSO_0226079_mutex\test.cpp, line 327

STL/tests/std/tests/VSO_0226079_mutex/test.cpp

Lines 324 to 327 in ea156e7

assert(time_execution([this] {
unique_lock<Mutex> ul(mtx, 50ms);
assert(!ul.owns_lock());
}) >= 50ms);

It appears that system_clock behavior may be making this test unreliable.
@StephanTLavavej StephanTLavavej added the test Related to test code label Nov 13, 2020
@StephanTLavavej StephanTLavavej mentioned this issue Nov 13, 2020
Merged
@CaseyCarter
Copy link
Member

Any idea why time_execution doesn't measure with steady_clock?

@AlexGuteniev AlexGuteniev mentioned this issue Sep 21, 2024
Merged
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed Something works now, yay! test Related to test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use steady_clock in timed mutex test AlexGuteniev/STL
2 participants
@CaseyCarter @StephanTLavavej