Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<filesystem>: Do we need to handle Volume GUID Paths? #5034

Open
StephanTLavavej opened this issue Oct 23, 2024 · 0 comments
Open

<filesystem>: Do we need to handle Volume GUID Paths? #5034

StephanTLavavej opened this issue Oct 23, 2024 · 0 comments
Labels
bug Something isn't working filesystem C++17 filesystem

Comments

@StephanTLavavej
Copy link
Member

See Naming a Volume in the Win32 docs.

This previously came up in #4291 addressed by #4311, but that fix didn't alter how we parse paths.

@xiangfan-ms observed that we never attempt to handle such paths:

STL/stl/inc/filesystem

Lines 569 to 572 in 2c9e3e7

_NODISCARD inline bool _Is_drive_prefix_with_slash_slash_question(const wstring_view _Text) {
// test if _Text starts with a \\?\X: prefix
return _Text.size() >= 6 && _Text._Starts_with(LR"(\\?\)"sv) && _Is_drive_prefix(_Text.data() + 4);
}

It's unclear to me how extensively we'd need to alter our code to handle volume GUID paths, but they appear to be cromulent so this appears to be a bug.

@StephanTLavavej StephanTLavavej added bug Something isn't working filesystem C++17 filesystem labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working filesystem C++17 filesystem
Projects
None yet
Development

No branches or pull requests

1 participant