Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1614R2 Adding Spaceship <=> To The Library #62

Closed
StephanTLavavej opened this issue Sep 6, 2019 · 1 comment · Fixed by #1678
Closed

P1614R2 Adding Spaceship <=> To The Library #62

StephanTLavavej opened this issue Sep 6, 2019 · 1 comment · Fixed by #1678
Labels
cxx20 C++20 feature fixed Something works now, yay!
Milestone
Conformance

Comments

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Sep 6, 2019 •
edited
Loading

P1614R2 Adding Spaceship <=> To The Library

LWG-3324 Special-case std::strong/weak/partial_order for pointers
LWG-3347 std::pair<T, U> now requires T and U to be less-than-comparable
LWG-3350 Simplify return type of lexicographical_compare_three_way
LWG-3354 has_strong_structural_equality has a meaningless definition
LWG-3380 common_type and comparison categories
LWG-3426 operator<=>(const unique_ptr<T, D>&, nullptr_t) can't get no satisfaction
LWG-3427 operator<=>(const shared_ptr<T>&, nullptr_t) definition ill-formed
LWG-3432 Missing requirement for comparison_category

Feature-test macro as of WG21-N4842 (note that WG21-P1614 proposed __cpp_lib_spaceship which was removed by WG21-P1902. Instead, __cpp_lib_three_way_comparison which was added for #64 WG21-P0768 "Library Support For The Spaceship Comparison Operator <=>" is being increased):
#define __cpp_lib_three_way_comparison 201907L
@StephanTLavavej StephanTLavavej added the cxx20 C++20 feature label Sep 6, 2019
@StephanTLavavej StephanTLavavej changed the title P1614R2 Adding <=> To The Library P1614R2 Adding Spaceship <=> To The Library Nov 27, 2019
@StephanTLavavej StephanTLavavej mentioned this issue Dec 4, 2019
Closed
@AdamBucior AdamBucior mentioned this issue Dec 14, 2019
Merged
4 tasks
@CaseyCarter
Copy link
Member

CaseyCarter commented Jan 24, 2020 •
edited by StephanTLavavej
Loading

NOTE: This proposal's changes to common_type are unnecessary after application of P1959R0 "Remove std::weak_equality and std::strong_equality". We have test coverage to validate this, and have submitted LWG-3380 to revert P1614R2's change to common_type.

@StephanTLavavej StephanTLavavej mentioned this issue Apr 30, 2020
Merged
@cbezault cbezault added this to the Conformance milestone May 7, 2020
@ahanamuk ahanamuk mentioned this issue Jul 15, 2020
Merged
@StephanTLavavej StephanTLavavej assigned cbezault and unassigned ahanamuk Sep 8, 2020
@StephanTLavavej StephanTLavavej mentioned this issue Oct 14, 2020
Merged
@StephanTLavavej StephanTLavavej mentioned this issue Nov 13, 2020
Closed
52 tasks
This was referenced Jan 26, 2021
Merged
Merged
@StephanTLavavej StephanTLavavej mentioned this issue Feb 5, 2021
Merged
@StephanTLavavej StephanTLavavej mentioned this issue Feb 13, 2021
Merged
This was referenced Feb 22, 2021
Merged
Merged
@StephanTLavavej StephanTLavavej added fixed Something works now, yay! and removed work in progress labels Feb 25, 2021
@StephanTLavavej StephanTLavavej removed their assignment Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cxx20 C++20 feature fixed Something works now, yay!
Projects
None yet
Milestone
Conformance
Development

Successfully merging a pull request may close this issue.

P1614R2 Adding Spaceship <=> To The Library StephanTLavavej/STL
4 participants
@CaseyCarter @cbezault @StephanTLavavej @ahanamuk