P2387R3 Pipe for user defined range adaptors #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
reviewed
Apr 21, 2022
cpplearner
reviewed
Apr 21, 2022
tests/std/tests/P2387R3_pipe_support_for_user_defined_range_adaptors/test.cpp
Show resolved
Hide resolved
fsb4000
suggested changes
Apr 21, 2022
fsb4000
suggested changes
Apr 22, 2022
tests/std/tests/VSO_0157762_feature_test_macros/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
…range adaptor closures got removed, because it is superfluous. Both will bind to const&
Most notably, `range_adaptor_closure<T>` now derives from `_Pipe::_Base<T>`, and the standard range adaptor closure objects derive directly from `_Pipe::_Base` as they did previously. I also eliminated a ton of repetition by implementing `operator|` for `_Pipe::_Base` as a non-member. (Since the non-member operator is squirreled away in `std::ranges::_Pipe` it is still effectively only found by ADL for things derived from `_Pipe::_Base` despite no longer being a hidden friend.)
CaseyCarter
approved these changes
Aug 19, 2022
tests/std/tests/VSO_0157762_feature_test_macros/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
|
This is incredible @Ukilele - thanks! I've pushed changes to (1) merge with main and resolve conflicts, (2) address the ABI concerns, and (3) simplify the "is this a range adaptor" concept a bit. |
tests/std/tests/P2387R3_pipe_support_for_user_defined_range_adaptors/env.lst
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Aug 20, 2022
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
reviewed
Aug 20, 2022
| && constructible_from<remove_cvref_t<_Left>, _Left> // | ||
| && constructible_from<remove_cvref_t<_Right>, _Right> // | ||
| _NODISCARD constexpr auto operator|(_Left&& __l, _Right&& __r) noexcept( | ||
| noexcept(_Pipeline{static_cast<_Left&&>(__l), static_cast<_Right&&>(__r)})) { |
There was a problem hiding this comment.
Ugh, this formatting is hideous, but not worth resetting the port. I'll clean these in a followup.
There was a problem hiding this comment.
Thanks. Yeah, I noticed how icky it was - perhaps because [[nodiscard]] is being concealed with the macro.
CaseyCarter
approved these changes
Aug 20, 2022
StephanTLavavej
dismissed
strega-nil-ms’s stale review
Casey addressed Nicole's comments
|
Thanks for making this ranges plumbing available to users! 😹 🎉 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2536