Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2387R3 Pipe for user defined range adaptors #2661

Merged
merged 37 commits into from
Aug 22, 2022
Merged

P2387R3 Pipe for user defined range adaptors #2661

merged 37 commits into from
Aug 22, 2022

Commits on Apr 12, 2022

  1. P2387R3 add bind_back

    @Ukilele
    Ukilele committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    341aa78 View commit details
    Browse the repository at this point in the history

  2. Use cassert instead of assert.h in test. Move tests into extra function

    @Ukilele
    Ukilele committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    ac7e672 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Merge branch 'microsoft:main' into pipe_for_user_defined_range_adaptors

    @Ukilele
    Ukilele committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    0aa40df View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Add std::ranges::range_adaptor_closure as well as tests

    @Ukilele
    Ukilele committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    1f390cb View commit details
    Browse the repository at this point in the history

  2. Use strict_concepts_latest_matrix.lst

    @Ukilele
    Ukilele committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    17f7b9a View commit details
    Browse the repository at this point in the history

  3. clang-format stl/inc/functional

    @Ukilele
    Ukilele committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    ccb8f5a View commit details
    Browse the repository at this point in the history

  4. clang-format yvals_core.h

    @Ukilele
    Ukilele committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    82d74a5 View commit details
    Browse the repository at this point in the history

  5. Use correct naming convetions

    @Ukilele
    Ukilele committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    57026a2 View commit details
    Browse the repository at this point in the history

  6. Remove superfluous empty line

    @Ukilele
    Ukilele committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    0a8b75c View commit details
    Browse the repository at this point in the history

  7. Adopt test for feature_test_macro to increased value of __cpp_lib_ran… 

    …ges in C++23-mode
    @Ukilele
    Ukilele committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    fe9aaf2 View commit details
    Browse the repository at this point in the history

  8. Add missing const

    @Ukilele
    Ukilele committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    c922228 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2022

  1. Define value of __cpp_lib_ranges depending on c++20 or c++23 mode

    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    097bde2 View commit details
    Browse the repository at this point in the history

  2. A function object only requires callable, not invocable

    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    2e16ab5 View commit details
    Browse the repository at this point in the history

  3. Overloads of ref-qualifier & and const&& for operator| composing two … 

    …range adaptor closures got removed, because it is superfluous. Both will bind to const&
    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    0afb061 View commit details
    Browse the repository at this point in the history

  4. Add __EDG__ workaround to range_adaptor_closure to mimic _Pipe::_Base

    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    d1a5c1b View commit details
    Browse the repository at this point in the history

  5. Let the standard range adaptor closure types inherit from range_adapt… 

    …or_closure
    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    55256e4 View commit details
    Browse the repository at this point in the history

  6. Remove namespace _Pipe and its content

    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    383ecfa View commit details
    Browse the repository at this point in the history

  7. Rename _StdPipe to _Pipe

    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    cbf346a View commit details
    Browse the repository at this point in the history

  8. Correct indentation of clang-format on comment

    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    c9ac78e View commit details
    Browse the repository at this point in the history

  9. clang-format

    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    c56d373 View commit details
    Browse the repository at this point in the history

  10. Add tests for mixing user defined and standard range adaptor closures

    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    26d9bc5 View commit details
    Browse the repository at this point in the history

  11. Only provide and use range_adaptor_closure when _HAS_CXX23 is defined

    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    ababc87 View commit details
    Browse the repository at this point in the history

  12. Fix typo Base -> _Base

    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    a32c71d View commit details
    Browse the repository at this point in the history

  13. As __cpp_lib_ranges is language mode sensitive, move it to the corres… 

    …ponding area
    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    1ba884e View commit details
    Browse the repository at this point in the history

  14. Merge content of _Pipe_cpp23 into _Pipe

    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    b03523e View commit details
    Browse the repository at this point in the history

  15. Add missing new line

    @Ukilele
    Ukilele committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    5faa912 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2022

  1. Add // to overcome clang-format and improve readability

    @Ukilele
    Ukilele committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    f191335 View commit details
    Browse the repository at this point in the history

  2. Remove std:: because of using namespace std;

    @Ukilele
    Ukilele committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    bb1033d View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Merge remote-tracking branch 'upstream/main' into pr/Ukilele/2661

    @strega-nil
    strega-nil committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    31f5f75 View commit details
    Browse the repository at this point in the history

  2. Nicole suggestions

    @strega-nil
    strega-nil committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    3278979 View commit details
    Browse the repository at this point in the history

  3. fix formatting

    @strega-nil
    strega-nil committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    3c88b92 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Merge branch 'main' into pipe_for_user_defined_range_adaptors

    @CaseyCarter
    CaseyCarter committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    ecd1631 View commit details
    Browse the repository at this point in the history

  2. Derive _As_rvalue_fn from _Range_Adaptor_base

    @CaseyCarter
    CaseyCarter committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    f3cfad7 View commit details
    Browse the repository at this point in the history

  3. Rename _Range_Adaptor_base => _Range_adaptor_base

    @CaseyCarter
    CaseyCarter committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    42752a1 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. Address review comments 

    Most notably, `range_adaptor_closure<T>` now derives from `_Pipe::_Base<T>`, and the standard range adaptor closure objects derive directly from `_Pipe::_Base` as they did previously. I also eliminated a ton of repetition by implementing `operator|` for `_Pipe::_Base` as a non-member. (Since the non-member operator is squirreled away in `std::ranges::_Pipe` it is still effectively only found by ADL for things derived from `_Pipe::_Base` despite no longer being a hidden friend.)
    @CaseyCarter
    CaseyCarter committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    c6206c4 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2022

  1. Code review nitpicks: Newline, comment.

    @StephanTLavavej
    StephanTLavavej committed Aug 20, 2022
    Configuration menu
    Copy the full SHA
    32e6cbb View commit details
    Browse the repository at this point in the history

  2. Add _NODISCARD to operator| overloads.

    @StephanTLavavej
    StephanTLavavej committed Aug 20, 2022
    Configuration menu
    Copy the full SHA
    2aed2b5 View commit details
    Browse the repository at this point in the history