Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds visualizers for
std::flat_map
with any combination ofstd::vector
andstd::deque
as the backing containers.I'm not sure if there's a way of making this smaller. The only difference between the types is the implementation of
size
,key_at
, andvalue_at
-<Expand>
is always the same. Ideally, there would be a way of having a condition based on the relevant type in from the template ($T4
forsize
andkey_at
;$T5
forvalue_at
). Alternatively, it would be fine keeping just the type where both containers are vectors, since that's the default, and have the fallback that shows keys and values.Initially, I had a
<DisplayString>{{ size={size()} }}</DisplayString>
, but I wanted to have at least some preview of the items contained in the map in the unexpanded view. Unfortunately, the[comparator]
still shows up in the display string, so only one value is shown.Code