Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make prompt-toolkit an optional dependency. #162

Closed
MarcCote opened this issue Apr 29, 2019 · 2 comments · Fixed by #189
Closed

Make prompt-toolkit an optional dependency. #162

MarcCote opened this issue Apr 29, 2019 · 2 comments · Fixed by #189
Labels
enhancement New feature or request

Comments

@MarcCote
Copy link
Contributor

Some systems (e.g. Google Colab) might have an old version of prompt-toolkit (TextWorld needs prompt_toolkit<2.1.0,>=2.0.0). Since that library is not essential to use TextWorld, I think it would be better to make it an optional dependency.

Related to #107
Reported by @krispymelody in #107 (comment)
@MarcCote MarcCote added the enhancement New feature or request label Apr 29, 2019
@MarcCote
Copy link
Contributor Author

While we are looking for a proper solution, @krispymelody you can use pip install https://github.com/MarcCote/TextWorld/archive/fix_162.zip which will only install the bare minimum. Since Google Colab already as some (older) libraries installed (e.g. gym, pillow, prompt-toolkit), it seems to be working fine except for visualization modules (mainly used for debugging).

@krispymelody
Copy link

@MarcCote Works perfectly now, appreciate the help!

@MarcCote MarcCote mentioned this issue Oct 12, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add graph visualization tool. MarcCote/TextWorld
2 participants
@MarcCote @krispymelody