Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish declaration file and js file when the option “Keep comments in TypeScript compiler output" is turned on #11774

Closed
dczuo opened this issue Oct 21, 2016 · 3 comments
Labels
Suggestion An idea for TypeScript Too Complex An issue which adding support for may be too complex for the value it adds

Comments

@dczuo
Copy link

dczuo commented Oct 21, 2016

Preserve comments in the declaration file have been able to provide prompt information in VS. Production environment using the uncompressed JS file helps locate exception, and retained in the .js file comments are unnecessary.
Proposals to add the options control only keep comments in declaration files.

@mhegazy
Copy link
Contributor

mhegazy commented Oct 21, 2016

I wounder if we should just keep comments in .d.ts files all the time, and possibly add --removeDeclarationComments

@mhegazy mhegazy added Suggestion An idea for TypeScript In Discussion Not yet reached consensus labels Oct 21, 2016
@dczuo dczuo closed this as completed Nov 24, 2016
@mhegazy mhegazy reopened this Nov 29, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Nov 29, 2016

if you do not mind, we would like to keep this open until the issue is addressed.

@dczuo dczuo changed the title Distinguish declaration file and js file when the option “Keep commons in TypeScript compiler output" is turned on Distinguish declaration file and js file when the option “Keep comments in TypeScript compiler output" is turned on Jan 2, 2017
@RyanCavanaugh RyanCavanaugh added Too Complex An issue which adding support for may be too complex for the value it adds and removed In Discussion Not yet reached consensus labels Mar 14, 2017
@RyanCavanaugh
Copy link
Member

Declined for the sake of flag complexity. Running a proper minifier over the output JS is part of any build which cares about output size.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Suggestion An idea for TypeScript Too Complex An issue which adding support for may be too complex for the value it adds
Projects
None yet
Development

No branches or pull requests

3 participants