-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag matching erratic in JSX javascript #12271
Comments
@dbaeumer is matching tags provided by a language service (i.e. TS Server)? I can't see anything in the doc - http://code.visualstudio.com/docs/extensions/language-support |
From @dbaeumer on November 15, 2016 1:26 Yes, the TS request message is called |
@bgashler1 can you share a project we can use? the highlighting only works if the language service can tell what that thing you are hovering over is, and not text based. so i will need to look at a project to see what went wrong. |
@mhegazy I think it would be good to reach out to @vvatikiotis since he is the first one to report this problem. I could give you a JS project with JSX in it, but I'm having a hard time getting any matching to work in JSX anymore (maybe something changed since then?). |
@bgashler1 do not think i have access to that repo. feel free to email me the file contents. |
I am seeing jsx tag matching working reliable with TS 2.7. Please open a new issue if you are still seeing some cases where it does not work |
From @bgashler1 on November 9, 2016 20:42
From @vvatikiotis:
microsoft/vscode#12402 (comment)
Steps to Reproduce:
HTML tag matching works in my theme, highlighting matching tags, when there are no JSX javascript expressions within the tags. However, tag highlighting works erratically when there are JSX javascript expressions within 2 enclosing HTML tags.
Works as intended:
Doesn't work:
Copied from original issue: microsoft/vscode#15264
The text was updated successfully, but these errors were encountered: