Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag matching erratic in JSX javascript #12271

Closed
waderyan opened this issue Nov 15, 2016 · 6 comments
Closed

Tag matching erratic in JSX javascript #12271

waderyan opened this issue Nov 15, 2016 · 6 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Needs More Info The issue still hasn't been fully clarified VS Code Tracked There is a VS Code equivalent to this issue

Comments

@waderyan
Copy link

From @bgashler1 on November 9, 2016 20:42

  • VSCode Version:
  • OS Version:

From @vvatikiotis:
microsoft/vscode#12402 (comment)

Steps to Reproduce:

HTML tag matching works in my theme, highlighting matching tags, when there are no JSX javascript expressions within the tags. However, tag highlighting works erratically when there are JSX javascript expressions within 2 enclosing HTML tags.

Works as intended:
image

Doesn't work:
image

Copied from original issue: microsoft/vscode#15264

@waderyan
Copy link
Author

@dbaeumer is matching tags provided by a language service (i.e. TS Server)? I can't see anything in the doc - http://code.visualstudio.com/docs/extensions/language-support

@waderyan waderyan self-assigned this Nov 15, 2016
@waderyan waderyan added Bug A bug in TypeScript js labels Nov 15, 2016
@waderyan
Copy link
Author

From @dbaeumer on November 15, 2016 1:26

Yes, the TS request message is called occurrences

@waderyan waderyan added VS Code Tracked There is a VS Code equivalent to this issue and removed editor labels Nov 15, 2016
@waderyan waderyan removed their assignment Nov 15, 2016
@waderyan waderyan added Bug A bug in TypeScript and removed Bug A bug in TypeScript labels Nov 15, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Dec 14, 2016

@bgashler1 can you share a project we can use?

the highlighting only works if the language service can tell what that thing you are hovering over is, and not text based. so i will need to look at a project to see what went wrong.

@mhegazy mhegazy added the Needs More Info The issue still hasn't been fully clarified label Dec 14, 2016
@bgashler1
Copy link

@mhegazy I think it would be good to reach out to @vvatikiotis since he is the first one to report this problem.

I could give you a JS project with JSX in it, but I'm having a hard time getting any matching to work in JSX anymore (maybe something changed since then?).

@mhegazy
Copy link
Contributor

mhegazy commented Jan 6, 2017

@bgashler1 do not think i have access to that repo. feel free to email me the file contents.

@mjbvz
Copy link
Contributor

mjbvz commented Dec 21, 2017

I am seeing jsx tag matching working reliable with TS 2.7. Please open a new issue if you are still seeing some cases where it does not work

@mjbvz mjbvz closed this as completed Dec 21, 2017
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jan 11, 2018
@mhegazy mhegazy added this to the TypeScript 2.7 milestone Jan 11, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Needs More Info The issue still hasn't been fully clarified VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

No branches or pull requests

4 participants