Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Caching resolutions in buildInfo and reusing them #50007

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

[WIP] Caching resolutions in buildInfo and reusing them #50007

wants to merge 31 commits into from

Conversation

sheetalkamat
Copy link
Member

No description provided.

@sheetalkamat sheetalkamat force-pushed the cacheModuleResolution branch 9 times, most recently from 890b6f2 to b52e333 Compare July 28, 2022 21:57
@DanielRosenwasser
Copy link
Member

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 28, 2022 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at b52e333. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 28, 2022 •
edited
Loading

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/130688/artifacts?artifactName=tgz&fileId=18A84789610F54A12CC6F784306EB3C05FB5E32B3B43CB29EDB8BD584D7457C402&fileName=/typescript-4.8.0-insiders.20220728.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@sheetalkamat sheetalkamat force-pushed the cacheModuleResolution branch 3 times, most recently from 8d300c0 to b484cfb Compare August 4, 2022 00:07
@sheetalkamat
Copy link
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 10, 2022 •
edited
Loading

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at db84122. You can monitor the build here.

@sheetalkamat
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 10, 2022 •
edited
Loading

Heya @sheetalkamat, I've started to run the perf test suite on this PR at db84122. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@sheetalkamat
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..50007
Metric main 50007 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 360,447k (± 0.02%) 360,767k (± 0.01%) +320k (+ 0.09%) 360,677k 360,903k
Parse Time 2.10s (± 0.64%) 2.09s (± 0.81%) -0.01s (- 0.48%) 2.06s 2.13s
Bind Time 0.89s (± 0.77%) 0.89s (± 0.77%) -0.01s (- 1.12%) 0.87s 0.90s
Check Time 6.04s (± 0.58%) 6.00s (± 0.55%) -0.04s (- 0.70%) 5.94s 6.09s
Emit Time 6.17s (± 0.69%) 6.16s (± 0.74%) -0.01s (- 0.19%) 6.07s 6.28s
Total Time 15.21s (± 0.44%) 15.13s (± 0.54%) -0.07s (- 0.49%) 14.96s 15.29s
Compiler-Unions - node (v10.16.3, x64)
Memory used 205,533k (± 0.03%) 205,722k (± 0.03%) +189k (+ 0.09%) 205,570k 205,898k
Parse Time 0.83s (± 0.82%) 0.84s (± 0.71%) +0.01s (+ 1.21%) 0.82s 0.85s
Bind Time 0.52s (± 1.45%) 0.52s (± 0.91%) -0.00s (- 0.19%) 0.51s 0.53s
Check Time 7.07s (± 0.32%) 7.11s (± 0.56%) +0.04s (+ 0.59%) 6.99s 7.16s
Emit Time 2.51s (± 0.84%) 2.51s (± 1.01%) -0.01s (- 0.28%) 2.46s 2.58s
Total Time 10.94s (± 0.34%) 10.98s (± 0.50%) +0.04s (+ 0.39%) 10.84s 11.06s
Monaco - node (v10.16.3, x64)
Memory used 343,974k (± 0.01%) 344,171k (± 0.02%) +197k (+ 0.06%) 344,076k 344,330k
Parse Time 1.60s (± 0.64%) 1.59s (± 0.96%) -0.01s (- 0.50%) 1.56s 1.62s
Bind Time 0.76s (± 1.14%) 0.76s (± 1.06%) -0.00s (- 0.52%) 0.75s 0.78s
Check Time 6.01s (± 0.30%) 6.04s (± 0.38%) +0.03s (+ 0.55%) 5.97s 6.07s
Emit Time 3.27s (± 1.03%) 3.29s (± 0.69%) +0.01s (+ 0.43%) 3.26s 3.36s
Total Time 11.65s (± 0.47%) 11.68s (± 0.33%) +0.03s (+ 0.26%) 11.59s 11.76s
TFS - node (v10.16.3, x64)
Memory used 305,275k (± 0.03%) 305,472k (± 0.03%) +198k (+ 0.06%) 305,187k 305,569k
Parse Time 1.29s (± 0.56%) 1.29s (± 0.53%) +0.01s (+ 0.47%) 1.28s 1.31s
Bind Time 0.72s (± 0.77%) 0.72s (± 0.50%) +0.01s (+ 0.84%) 0.72s 0.73s
Check Time 5.44s (± 0.74%) 5.47s (± 0.59%) +0.03s (+ 0.57%) 5.39s 5.53s
Emit Time 3.47s (± 1.03%) 3.45s (± 0.97%) -0.01s (- 0.35%) 3.39s 3.54s
Total Time 10.91s (± 0.29%) 10.94s (± 0.30%) +0.03s (+ 0.26%) 10.85s 11.00s
material-ui - node (v10.16.3, x64)
Memory used 469,646k (± 0.01%) 470,007k (± 0.01%) +361k (+ 0.08%) 469,945k 470,095k
Parse Time 1.83s (± 0.35%) 1.84s (± 0.60%) +0.01s (+ 0.49%) 1.82s 1.87s
Bind Time 0.68s (± 1.83%) 0.68s (± 1.49%) -0.01s (- 1.17%) 0.65s 0.70s
Check Time 14.52s (± 0.66%) 14.69s (± 0.38%) +0.17s (+ 1.17%) 14.56s 14.86s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 17.03s (± 0.57%) 17.20s (± 0.35%) +0.17s (+ 1.00%) 17.05s 17.37s
xstate - node (v10.16.3, x64)
Memory used 578,667k (± 0.02%) 579,318k (± 0.02%) +652k (+ 0.11%) 579,096k 579,662k
Parse Time 2.60s (± 0.46%) 2.61s (± 0.46%) +0.01s (+ 0.42%) 2.59s 2.63s
Bind Time 1.02s (± 0.69%) 1.02s (± 0.65%) +0.00s (+ 0.10%) 1.01s 1.04s
Check Time 1.56s (± 0.68%) 1.58s (± 0.56%) +0.01s (+ 0.83%) 1.56s 1.60s
Emit Time 0.07s (± 3.14%) 0.07s (± 0.00%) -0.00s (- 1.41%) 0.07s 0.07s
Total Time 5.25s (± 0.28%) 5.28s (± 0.34%) +0.03s (+ 0.51%) 5.23s 5.33s
Angular - node (v12.1.0, x64)
Memory used 337,996k (± 0.02%) 338,185k (± 0.03%) +188k (+ 0.06%) 337,990k 338,343k
Parse Time 2.10s (± 0.59%) 2.09s (± 0.55%) -0.01s (- 0.29%) 2.06s 2.12s
Bind Time 0.86s (± 2.07%) 0.85s (± 0.78%) -0.01s (- 1.51%) 0.84s 0.86s
Check Time 5.85s (± 0.52%) 5.87s (± 0.51%) +0.02s (+ 0.32%) 5.82s 5.95s
Emit Time 6.40s (± 0.75%) 6.37s (± 0.99%) -0.02s (- 0.38%) 6.25s 6.53s
Total Time 15.20s (± 0.43%) 15.18s (± 0.56%) -0.02s (- 0.16%) 15.01s 15.36s
Compiler-Unions - node (v12.1.0, x64)
Memory used 193,256k (± 0.04%) 193,138k (± 0.15%) -119k (- 0.06%) 192,266k 193,530k
Parse Time 0.83s (± 1.13%) 0.83s (± 0.57%) 0.00s ( 0.00%) 0.82s 0.84s
Bind Time 0.54s (± 1.25%) 0.55s (± 0.60%) +0.01s (+ 1.10%) 0.54s 0.56s
Check Time 6.68s (± 0.55%) 6.70s (± 1.06%) +0.03s (+ 0.39%) 6.53s 6.90s
Emit Time 2.53s (± 0.76%) 2.55s (± 0.57%) +0.01s (+ 0.51%) 2.51s 2.57s
Total Time 10.59s (± 0.38%) 10.63s (± 0.76%) +0.04s (+ 0.40%) 10.47s 10.87s
Monaco - node (v12.1.0, x64)
Memory used 326,929k (± 0.02%) 327,082k (± 0.02%) +154k (+ 0.05%) 326,889k 327,167k
Parse Time 1.59s (± 0.84%) 1.59s (± 1.11%) -0.01s (- 0.56%) 1.56s 1.64s
Bind Time 0.74s (± 0.67%) 0.74s (± 0.80%) 0.00s ( 0.00%) 0.73s 0.76s
Check Time 5.82s (± 0.42%) 5.82s (± 0.43%) +0.00s (+ 0.05%) 5.78s 5.88s
Emit Time 3.30s (± 0.94%) 3.30s (± 0.47%) -0.00s (- 0.06%) 3.27s 3.33s
Total Time 11.46s (± 0.41%) 11.46s (± 0.35%) -0.01s (- 0.05%) 11.39s 11.55s
TFS - node (v12.1.0, x64)
Memory used 289,840k (± 0.02%) 290,006k (± 0.02%) +166k (+ 0.06%) 289,887k 290,205k
Parse Time 1.30s (± 0.82%) 1.30s (± 0.63%) +0.01s (+ 0.39%) 1.28s 1.32s
Bind Time 0.71s (± 1.06%) 0.72s (± 1.08%) +0.01s (+ 0.84%) 0.71s 0.74s
Check Time 5.38s (± 0.63%) 5.39s (± 0.36%) +0.01s (+ 0.20%) 5.35s 5.43s
Emit Time 3.54s (± 1.33%) 3.54s (± 0.88%) +0.00s (+ 0.00%) 3.47s 3.62s
Total Time 10.93s (± 0.75%) 10.95s (± 0.44%) +0.02s (+ 0.20%) 10.83s 11.06s
material-ui - node (v12.1.0, x64)
Memory used 448,688k (± 0.01%) 448,997k (± 0.07%) +309k (+ 0.07%) 447,814k 449,224k
Parse Time 1.82s (± 0.27%) 1.82s (± 0.59%) -0.00s (- 0.16%) 1.80s 1.85s
Bind Time 0.67s (± 0.55%) 0.67s (± 1.36%) -0.01s (- 0.89%) 0.64s 0.69s
Check Time 13.05s (± 0.73%) 13.09s (± 1.03%) +0.04s (+ 0.30%) 12.90s 13.48s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.55s (± 0.62%) 15.58s (± 0.88%) +0.03s (+ 0.18%) 15.38s 15.99s
xstate - node (v12.1.0, x64)
Memory used 547,286k (± 1.33%) 544,647k (± 0.02%) -2,639k (- 0.48%) 544,491k 544,891k
Parse Time 2.53s (± 0.42%) 2.55s (± 0.38%) +0.02s (+ 0.71%) 2.53s 2.58s
Bind Time 1.04s (± 1.03%) 1.02s (± 0.92%) -0.02s (- 1.54%) 1.00s 1.04s
Check Time 1.50s (± 0.33%) 1.51s (± 1.00%) +0.00s (+ 0.27%) 1.49s 1.55s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.15s (± 0.40%) 5.16s (± 0.36%) +0.01s (+ 0.14%) 5.12s 5.20s
Angular - node (v14.15.1, x64)
Memory used 336,247k (± 0.01%) 336,489k (± 0.01%) +242k (+ 0.07%) 336,400k 336,553k
Parse Time 2.06s (± 0.31%) 2.06s (± 0.35%) +0.00s (+ 0.19%) 2.05s 2.08s
Bind Time 0.89s (± 0.41%) 0.89s (± 0.58%) -0.00s (- 0.45%) 0.88s 0.90s
Check Time 5.82s (± 0.32%) 5.88s (± 0.55%) +0.06s (+ 1.08%) 5.81s 5.94s
Emit Time 6.36s (± 0.41%) 6.43s (± 0.50%) +0.07s (+ 1.04%) 6.34s 6.50s
Total Time 15.13s (± 0.25%) 15.26s (± 0.32%) +0.13s (+ 0.89%) 15.17s 15.37s
Compiler-Unions - node (v14.15.1, x64)
Memory used 191,680k (± 0.12%) 192,007k (± 0.01%) +328k (+ 0.17%) 191,959k 192,059k
Parse Time 0.85s (± 0.61%) 0.85s (± 0.70%) +0.01s (+ 0.59%) 0.84s 0.87s
Bind Time 0.57s (± 1.36%) 0.58s (± 0.38%) +0.01s (+ 1.40%) 0.57s 0.58s
Check Time 6.67s (± 0.65%) 6.72s (± 0.51%) +0.05s (+ 0.78%) 6.64s 6.77s
Emit Time 2.49s (± 1.06%) 2.49s (± 0.46%) -0.00s (- 0.20%) 2.47s 2.52s
Total Time 10.58s (± 0.56%) 10.64s (± 0.38%) +0.06s (+ 0.59%) 10.55s 10.72s
Monaco - node (v14.15.1, x64)
Memory used 325,744k (± 0.00%) 325,917k (± 0.01%) +173k (+ 0.05%) 325,868k 325,954k
Parse Time 1.58s (± 0.67%) 1.58s (± 0.55%) -0.00s (- 0.06%) 1.57s 1.61s
Bind Time 0.78s (± 1.19%) 0.78s (± 0.74%) +0.00s (+ 0.26%) 0.77s 0.79s
Check Time 5.69s (± 0.43%) 5.71s (± 0.64%) +0.02s (+ 0.33%) 5.66s 5.84s
Emit Time 3.36s (± 0.75%) 3.39s (± 0.84%) +0.03s (+ 1.04%) 3.34s 3.47s
Total Time 11.40s (± 0.45%) 11.46s (± 0.39%) +0.05s (+ 0.48%) 11.37s 11.58s
TFS - node (v14.15.1, x64)
Memory used 288,908k (± 0.01%) 289,035k (± 0.01%) +127k (+ 0.04%) 288,969k 289,094k
Parse Time 1.35s (± 1.45%) 1.31s (± 0.64%) -0.03s (- 2.53%) 1.29s 1.33s
Bind Time 0.74s (± 1.35%) 0.75s (± 1.40%) +0.01s (+ 1.21%) 0.73s 0.78s
Check Time 5.35s (± 0.44%) 5.36s (± 0.47%) +0.02s (+ 0.36%) 5.31s 5.41s
Emit Time 3.57s (± 1.88%) 3.54s (± 2.24%) -0.03s (- 0.90%) 3.41s 3.72s
Total Time 11.01s (± 0.66%) 10.97s (± 0.83%) -0.04s (- 0.38%) 10.83s 11.19s
material-ui - node (v14.15.1, x64)
Memory used 446,736k (± 0.07%) 447,365k (± 0.00%) +629k (+ 0.14%) 447,332k 447,395k
Parse Time 1.87s (± 0.43%) 1.87s (± 0.45%) -0.00s (- 0.05%) 1.85s 1.89s
Bind Time 0.72s (± 0.80%) 0.72s (± 0.55%) -0.00s (- 0.28%) 0.71s 0.73s
Check Time 13.20s (± 0.72%) 13.21s (± 0.42%) +0.00s (+ 0.03%) 13.04s 13.31s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.80s (± 0.64%) 15.80s (± 0.37%) -0.00s (- 0.01%) 15.64s 15.92s
xstate - node (v14.15.1, x64)
Memory used 541,914k (± 0.00%) 542,530k (± 0.00%) +616k (+ 0.11%) 542,495k 542,562k
Parse Time 2.60s (± 0.43%) 2.61s (± 0.41%) +0.01s (+ 0.38%) 2.59s 2.63s
Bind Time 1.15s (± 0.98%) 1.16s (± 0.67%) +0.01s (+ 0.87%) 1.15s 1.18s
Check Time 1.55s (± 0.47%) 1.57s (± 0.54%) +0.02s (+ 1.10%) 1.55s 1.59s
Emit Time 0.07s (± 4.95%) 0.08s (± 4.79%) +0.00s (+ 1.33%) 0.07s 0.08s
Total Time 5.38s (± 0.34%) 5.42s (± 0.27%) +0.04s (+ 0.74%) 5.38s 5.45s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50007 10
Baseline main 10

TSServer

Comparison Report - main..50007
Metric main 50007 Delta Best Worst
Compiler-UnionsTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 1,454ms (± 0.60%) 1,454ms (± 0.58%) -0ms (- 0.02%) 1,436ms 1,474ms
Req 2 - geterr 3,618ms (± 0.57%) 3,619ms (± 0.61%) +1ms (+ 0.03%) 3,555ms 3,655ms
Req 3 - references 275ms (± 0.57%) 278ms (± 1.17%) +3ms (+ 1.16%) 270ms 286ms
Req 4 - navto 231ms (± 1.33%) 233ms (± 0.72%) +2ms (+ 0.78%) 229ms 236ms
Req 5 - completionInfo count 1,355 (± 0.00%) 1,355 (± 0.00%) 0 ( 0.00%) 1,355 1,355
Req 5 - completionInfo 65ms (± 3.76%) 63ms (± 3.67%) -2ms (- 2.79%) 59ms 68ms
CompilerTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 1,558ms (± 0.31%) 1,557ms (± 0.45%) -0ms (- 0.03%) 1,545ms 1,574ms
Req 2 - geterr 2,276ms (± 0.47%) 2,279ms (± 0.39%) +3ms (+ 0.15%) 2,257ms 2,294ms
Req 3 - references 298ms (± 0.58%) 297ms (± 0.55%) -1ms (- 0.17%) 294ms 300ms
Req 4 - navto 235ms (± 2.44%) 239ms (± 1.88%) +4ms (+ 1.79%) 227ms 246ms
Req 5 - completionInfo count 1,517 (± 0.00%) 1,517 (± 0.00%) 0 ( 0.00%) 1,517 1,517
Req 5 - completionInfo 69ms (± 0.75%) 69ms (± 0.81%) -0ms (- 0.15%) 68ms 70ms
xstateTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 2,164ms (± 0.29%) 2,176ms (± 0.52%) +12ms (+ 0.53%) 2,149ms 2,204ms
Req 2 - geterr 773ms (± 0.80%) 776ms (± 0.54%) +3ms (+ 0.32%) 765ms 785ms
Req 3 - references 97ms (± 1.62%) 97ms (± 1.94%) -0ms (- 0.41%) 91ms 99ms
Req 4 - navto 253ms (± 1.09%) 254ms (± 1.23%) +1ms (+ 0.28%) 247ms 262ms
Req 5 - completionInfo count 3,244 (± 0.00%) 3,244 (± 0.00%) 0 ( 0.00%) 3,244 3,244
Req 5 - completionInfo 271ms (± 1.30%) 271ms (± 1.61%) -0ms (- 0.11%) 263ms 280ms
Compiler-UnionsTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 1,481ms (± 0.77%) 1,482ms (± 0.51%) +1ms (+ 0.05%) 1,464ms 1,493ms
Req 2 - geterr 3,388ms (± 0.50%) 3,394ms (± 0.88%) +6ms (+ 0.19%) 3,321ms 3,444ms
Req 3 - references 262ms (± 0.54%) 261ms (± 0.79%) -0ms (- 0.04%) 258ms 267ms
Req 4 - navto 204ms (± 0.66%) 205ms (± 1.12%) +1ms (+ 0.34%) 200ms 211ms
Req 5 - completionInfo count 1,355 (± 0.00%) 1,355 (± 0.00%) 0 ( 0.00%) 1,355 1,355
Req 5 - completionInfo 77ms (±11.17%) 61ms (±11.32%) 🟩-15ms (-19.74%) 57ms 89ms
CompilerTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 1,561ms (± 0.53%) 1,565ms (± 0.38%) +4ms (+ 0.25%) 1,554ms 1,577ms
Req 2 - geterr 2,206ms (± 0.23%) 2,210ms (± 0.55%) +4ms (+ 0.17%) 2,196ms 2,246ms
Req 3 - references 271ms (± 0.44%) 273ms (± 0.91%) +2ms (+ 0.59%) 268ms 278ms
Req 4 - navto 214ms (± 0.54%) 216ms (± 1.07%) +2ms (+ 0.70%) 211ms 223ms
Req 5 - completionInfo count 1,517 (± 0.00%) 1,517 (± 0.00%) 0 ( 0.00%) 1,517 1,517
Req 5 - completionInfo 62ms (± 3.97%) 62ms (± 3.92%) +0ms (+ 0.65%) 56ms 66ms
xstateTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 2,101ms (± 0.29%) 2,111ms (± 0.62%) +10ms (+ 0.47%) 2,080ms 2,140ms
Req 2 - geterr 761ms (± 0.28%) 763ms (± 0.65%) +2ms (+ 0.20%) 752ms 775ms
Req 3 - references 65ms (± 1.42%) 67ms (± 0.83%) +2ms (+ 3.07%) 66ms 68ms
Req 4 - navto 239ms (± 1.59%) 244ms (± 0.63%) +4ms (+ 1.84%) 240ms 247ms
Req 5 - completionInfo count 3,244 (± 0.00%) 3,244 (± 0.00%) 0 ( 0.00%) 3,244 3,244
Req 5 - completionInfo 264ms (± 1.03%) 264ms (± 0.79%) +0ms (+ 0.08%) 258ms 268ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,529ms (± 0.61%) 1,532ms (± 0.37%) +3ms (+ 0.21%) 1,518ms 1,543ms
Req 2 - geterr 3,534ms (± 0.70%) 3,542ms (± 0.63%) +8ms (+ 0.24%) 3,494ms 3,591ms
Req 3 - references 277ms (± 0.71%) 279ms (± 0.89%) +2ms (+ 0.65%) 274ms 285ms
Req 4 - navto 218ms (± 0.52%) 217ms (± 0.71%) -1ms (- 0.32%) 215ms 222ms
Req 5 - completionInfo count 1,355 (± 0.00%) 1,355 (± 0.00%) 0 ( 0.00%) 1,355 1,355
Req 5 - completionInfo 55ms (± 1.96%) 58ms (± 6.38%) +3ms (+ 5.83%) 54ms 66ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,599ms (± 0.53%) 1,600ms (± 0.60%) +1ms (+ 0.08%) 1,577ms 1,628ms
Req 2 - geterr 2,326ms (± 0.32%) 2,353ms (± 0.42%) +27ms (+ 1.16%) 2,325ms 2,366ms
Req 3 - references 285ms (± 0.47%) 287ms (± 0.54%) +2ms (+ 0.60%) 284ms 290ms
Req 4 - navto 237ms (± 2.73%) 232ms (± 1.59%) -5ms (- 2.07%) 225ms 244ms
Req 5 - completionInfo count 1,517 (± 0.00%) 1,517 (± 0.00%) 0 ( 0.00%) 1,517 1,517
Req 5 - completionInfo 53ms (± 0.84%) 53ms (± 0.90%) -0ms (- 0.19%) 52ms 54ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,226ms (± 0.52%) 2,225ms (± 0.45%) -1ms (- 0.06%) 2,202ms 2,252ms
Req 2 - geterr 781ms (± 0.44%) 783ms (± 0.55%) +2ms (+ 0.27%) 776ms 791ms
Req 3 - references 65ms (± 0.86%) 67ms (±10.12%) +2ms (+ 3.24%) 62ms 94ms
Req 4 - navto 249ms (± 0.66%) 251ms (± 0.35%) +2ms (+ 0.72%) 248ms 252ms
Req 5 - completionInfo count 3,244 (± 0.00%) 3,244 (± 0.00%) 0 ( 0.00%) 3,244 3,244
Req 5 - completionInfo 267ms (± 0.63%) 268ms (± 0.58%) +1ms (+ 0.37%) 265ms 272ms
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v10.16.3, x64)
  • Compiler-UnionsTSServer - node (v12.1.0, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v10.16.3, x64)
  • CompilerTSServer - node (v12.1.0, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v10.16.3, x64)
  • xstateTSServer - node (v12.1.0, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50007 10
Baseline main 10

Developer Information:

Download Benchmark

@sheetalkamat
Copy link
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 10, 2022 •
edited
Loading

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 7612a5e. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 10, 2022 •
edited
Loading

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/131503/artifacts?artifactName=tgz&fileId=91DA033B95F9AD1D6AEC4586BFFD81C4E8569BFE37AC196CEB3B5E64FD2BF7BF02&fileName=/typescript-4.9.0-insiders.20220810.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@sheetalkamat sheetalkamat force-pushed the cacheModuleResolution branch 5 times, most recently from 7bb44e7 to edc8d58 Compare December 9, 2022 22:40
@sheetalkamat
Test for module resolutions from different directories
d55ab98
@sheetalkamat
Handle resolutions that would be same in ancestor directory and can b…
ce07d0e 
…e derived through ancestor map
@sheetalkamat
Do not store failed lookups with cacheResolution option if it is reso…
959206d 
…lved to a file since they do not matter
@sheetalkamat
Add tests where module resolution caches should reuse the resolutions…
0446430 
… from buildInfo
@sheetalkamat
Reusing resolutions in tsserver scenario
207226a
@sheetalkamat
Set old program build info as a location to look for from module reso…
591960e 
…lution caches
@sheetalkamat
Modify resolution cache to update on program creation completion
71ebed9
@sheetalkamat
Remove files that are not in program from cache of unresolved imports
4d127fa
@sheetalkamat
Tests for unresolved imports from multiple places
feb3220
@sheetalkamat
More tests for cache reuse directory structure
84cda33
@sheetalkamat
Start using cache as perDirectory lookup
2219b5d
@sheetalkamat
Add tests where cache resoluition is incorrectly used because of not …
6261b6c 
…checking affected locations
@sheetalkamat
Store package json hash in buildinfo
e1ed9ea
@sheetalkamat
Use the hashes to verify the affecting location before using the reso…
7de4780 
…lution
@sheetalkamat
Add tests for package json edits
5c11252
@sheetalkamat
Store package.json for the directories in buildinfo
e21738c
@sheetalkamat
During cacheResolutions dont watch failed lookups and dont look at th…
be5ecb2 
…ose package.json if one exists per buildInfo
@sheetalkamat
Dont store package json path if its found in same directory
78e215f
@sheetalkamat
Cache packagejson scopes per directory
1e123ec
@sheetalkamat
Dont store isExternalLibraryImport in the buildInfo
81a1af9
@DanielRosenwasser DanielRosenwasser mentioned this pull request Feb 28, 2023
Closed
@sheetalkamat sheetalkamat mentioned this pull request Mar 23, 2023
Open
5 tasks
@DanielRosenwasser DanielRosenwasser mentioned this pull request May 17, 2023
Closed
@DanielRosenwasser DanielRosenwasser mentioned this pull request Aug 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheetalkamat @DanielRosenwasser @typescript-bot