-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNW] GetForCurrentView API alternatives for islands #114
Comments
Thanks - I see a bunch of APIs for this already available to your needs. You could potentially add the layer of indirection now, then help us make that indirection functionality part of Project Reunion. For example:
|
@jonwis any ideas for the other scenarios? e.g. detecting when the software keyboard shows/hides, etc.? |
For soft keyboard, can you use https://docs.microsoft.com/en-us/windows/win32/api/inputpaneinterop/nn-inputpaneinterop-iinputpaneinterop and then https://docs.microsoft.com/en-us/windows/uwp/design/input/respond-to-the-presence-of-the-touch-keyboard ? What's left? |
@asklar - anything left (see Jon's question above)? |
@stevewri @jonwis I was hoping Reunion would be this magic box I could call an API on and it would just work regardless of context (uwp/island/...). |
+1 for case in |
@asklar, @imbushuo I wrote several samples using the Win32 APIs that cover the majority of the gaps that there are in the platform. You can take a look at https://github.com/marb2000/DesktopWindow. Per the current engineering plan, these functionalities are not in Reunion v1. |
Currently, it is recommended to use the various I*Interop APIs using HWNDs. See |
React Native for Windows doesn't currently officially support islands today (on system xaml nor winui3) but I’m doing work to bring up islands support.
We have usages of a few WinRT types via GetForCurrentView which won't work in island scenarios, this tracks pursuing alternatives in Reunion that allow us to have a unified calling pattern for both win32 and UWP.
Members of DisplayInformation we use (after doing a GetForCurrentView):
These last 2 are used to expose them to the JS side of apps and libraries.
There are a couple of other places where we do things like GetForCurrentView that we’ll need to figure out how to achieve with islands:
We do that to know when the on screen keyboard shows/hides and raise JS events to that effect so that the UI can re-layout.
This might be ok to not hook up in island scenarios if we never have a device with back buttons that can also run Win32 apps
This is used to determine whether we should display in RTL or LTR. I’m assuming the alternative is to do GetLayout(hwnd) == LAYOUT_RTL instead?
The text was updated successfully, but these errors were encountered: