-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADFS 2.0 detection and fix by replacing strings #37
Comments
Comment by bongiovimatthew-microsoft I think this change looks good. @rattuscz, would you mind running the tests to make sure nothing has been regressed? |
Comment by rattuscz Could not make it work, even with the original code Pester fails.
|
Comment by bongiovimatthew-microsoft That's strange. It looks like the tests all pass for me (both the original version, and using your code changes). This merge should be good to go once I get one more sign off from my side. I'm not sure why the tests didn't work on your end. Maybe your Pester version isn't current? Here's my output:
|
Comment by rattuscz I've actually used same version - 4.3.1, was latest stable in Pester repo. |
Comment by bongiovimatthew-microsoft That's very strange. Well I was able to run the test pass for you, and it looks good. If you're interested in debugging the tests on your side, you could try running in the PowerShell ISE and see if you can learn anything more. I'm happy to help debug if you are able to get more info from ISE. |
Issue by rattuscz
Monday May 28, 2018 at 14:36 GMT
Originally opened as microsoft/adfsLogTools#19
related #16
Well I've ended up on this "solution".
Basically we need to evaluate available logs on the remote machines themselves, then replace
"AD FS"
with"AD FS 2.0"
in log name, provider and also in query.This is due to strings formatted before the log/provider name is sent to remote server (
MakeQuery
receives already processed query and log.Also not sure about using hardcoded strings in replacement, but using $script on remote would mean to either pass them all as params OR prepopulate the session with them before calling
MakeQuery
Due to this I believe hardcoding
AD FS 2.0
is a bit better as it's legacy and thus is not likely to ever change again.Suggestions welcome in any way :-)
rattuscz included the following code: https://github.com/Microsoft/adfsLogTools/pull/19/commits
The text was updated successfully, but these errors were encountered: