Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect check against Content-Type instead of content-type in httpRequest #3992

Closed
NickHeap2 opened this issue Dec 1, 2021 · 1 comment · Fixed by #3993
Closed

Incorrect check against Content-Type instead of content-type in httpRequest #3992

NickHeap2 opened this issue Dec 1, 2021 · 1 comment · Fixed by #3993
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository.

Comments

@NickHeap2
Copy link
Contributor

Describe the bug

Incorrect check against Content-Type instead of content-type in httpRequest.
if (key.toLowerCase() === 'Content-Type')
should be
if (key.toLowerCase() === 'content-type')
Currently the check doesn't change content-type to Content-Type.

To Reproduce

Bug is in libraries/botbuilder-dialogs-adaptive/src/actions/httpRequest.ts at line 271

Expected behavior

The check should change content-type to Content-Type.

Additional context

Happy to submit a PR with the change.
@NickHeap2 NickHeap2 added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Dec 1, 2021
@NickHeap2 NickHeap2 mentioned this issue Dec 1, 2021
Merged
@stevkan stevkan added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Dec 1, 2021
@joshgummersall
Copy link
Contributor

@NickHeap2 in the fetch spec, my understanding is headers are serialized as case-insensitive. The logic in your PR is sound, but I don't think the fix will actually change any behavior?

@axelsrz axelsrz added customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository.
Projects
None yet
Milestone
No milestone
4 participants
@joshgummersall @axelsrz @stevkan @NickHeap2