Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#6019] Remove redundant project dependencies from AI Recognizers (#6067) #4064

Closed
github-actions bot opened this issue Jan 20, 2022 · 1 comment · Fixed by #4152
Closed

port: [#6019] Remove redundant project dependencies from AI Recognizers (#6067) #4064

github-actions bot opened this issue Jan 20, 2022 · 1 comment · Fixed by #4152
Assignees
@JuanAr
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. P1 Painful if we don't fix, won't block releasing parity The issue describes a gap in parity between two or more platforms.
Milestone
R16

Comments

@github-actions
Copy link

The changes in [#6019] Remove redundant project dependencies from AI Recognizers (#6067) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6019

Note: The same dependency structure was corroborated for JavaScript and Python. Only JavaScript has the similar case as DotNet, whereas Python doesn't.

Description

This PR removes redundant dependencies for Dialogs.Adaptive, AI.Orchestrator and AI.QnA.

Specific Changes

  • Dialogs.Adaptive
    • Removed AdaptiveExpressions dependency reference from <ProjectReference/> and <PackageReference/>.
  • AI.Orchestrator
    • Removed Microsoft.Bot.Builder.Dialogs dependency reference from <ProjectReference/>.
  • AI.QnA
    • Removed AdaptiveExpressions and Microsoft.Bot.Builder dependencies' references from <ProjectReference/> and <PackageReference/>.

Testing

The following image shows the CI pipeline running successfully after the changes.
image

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Jan 20, 2022
@mrivera-ms mrivera-ms added the P1 Painful if we don't fix, won't block releasing label Mar 3, 2022
@mrivera-ms mrivera-ms added this to the R16 milestone Mar 3, 2022
@ceciliaavila
Copy link
Collaborator

@mrivera-ms in progress

@ceciliaavila ceciliaavila mentioned this issue Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. P1 Painful if we don't fix, won't block releasing parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
R16
3 participants
@JuanAr @ceciliaavila @mrivera-ms