Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ms-rest-js to latest version (2.6.0) #4094

Closed
ceciliaavila opened this issue Feb 3, 2022 · 0 comments · Fixed by #4161
Closed

Upgrade ms-rest-js to latest version (2.6.0) #4094

ceciliaavila opened this issue Feb 3, 2022 · 0 comments · Fixed by #4161
Assignees
@JuanAr
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team. P1 Painful if we don't fix, won't block releasing
Milestone
R16

Comments

@ceciliaavila
Copy link
Collaborator

Versions

What package version of the SDK are you using - 4.15.0
What nodejs version are you using 16.13.1

Description

As part of supporting Node.js 16 (#3756) we should update the @azure/ms-rest-js package in the SDK libraries as its current version (1.9.1) is using uuid 3.4.0 which is deprecated.

Additional Context

These are the warnings shown when installing the packages on a bot using botbuilder 4.15.0
image
@ceciliaavila ceciliaavila added needs-triage The issue has just been created and it has not been reviewed by the team. feature-request A request for new functionality or an enhancement to an existing one. labels Feb 3, 2022
@mrivera-ms mrivera-ms added the P1 Painful if we don't fix, won't block releasing label Mar 3, 2022
@mrivera-ms mrivera-ms added this to the R16 milestone Mar 3, 2022
@ceciliaavila ceciliaavila mentioned this issue Mar 16, 2022
Merged
@ceciliaavila ceciliaavila linked a pull request Mar 16, 2022 that will close this issue
fix: [#4123][botframework-connector] upgrade and clean up dependencies #4161
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team. P1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
R16
Development

Successfully merging a pull request may close this issue.

fix: [#4123][botframework-connector] upgrade and clean up dependencies microsoft/botbuilder-js
3 participants
@JuanAr @ceciliaavila @mrivera-ms