Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#6354] isMatch adaptive expression returns error when value is null or empty string (#6426) #4310

Closed
github-actions bot opened this issue Aug 9, 2022 · 0 comments · Fixed by #4343
Assignees
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

The changes in [#6354] isMatch adaptive expression returns error when value is null or empty string (#6426) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6354

Description

This PR fixes the issue where the isMatch adaptive expression built-in function returns the error message regular expression is empty when the value is null or an empty string to just being processed by the evaluator instead.

Specific Changes

  • Updates the IsMatch built-in function to handle empty strings and null values by the evaluator.
  • Adds new unit tests to handle empty string and null values for the IsMatch function.

Testing

The following image shows the tests passing successfully.
image

Please review and, if necessary, port the changes.

@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
1 participant