Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#6432] TeamsInfo.GetMemberAsync(...) doesn't work properly in Skill Bot scenario, it returns http 405 error (#6443) #4317

Closed
github-actions bot opened this issue Aug 30, 2022 · 0 comments · Fixed by #4344
Closed

port: [#6432] TeamsInfo.GetMemberAsync(...) doesn't work properly in Skill Bot scenario, it returns http 405 error (#6443) #4317

github-actions bot opened this issue Aug 30, 2022 · 0 comments · Fixed by #4344
Assignees
@JuanAr
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

The changes in [#6432] TeamsInfo.GetMemberAsync(...) doesn't work properly in Skill Bot scenario, it returns http 405 error (#6443) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6432

Description

This PR fixes the error thrown when executing the TeamsInfo.GetMemberAsync from a skill bot implementing the method in the CloudSkillHandler class.

Specific Changes

  • Added the HandleGetConversationMemberAsync and OnGetConversationMemberAsync methods in ChannelServiceHandlerBase.
  • Added the OnGetConversationMemberAsync method in the CloudSkillHandler class.
  • Added the implementation of the OnGetMemberAsync method in the SkillHandlerImpl class.
  • Added the GetConversationMemberAsync method in the ChannelServiceController class.
  • Added unit test in CloudSkillHandlerTests.

Testing

These images show the skill bot retrieving the member's information successfully and the new unit test passing.
image
image

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Aug 30, 2022
@ceciliaavila ceciliaavila mentioned this issue Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
1 participant
@JuanAr