Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample tests where response is coming from https://www.luis.ai/ #1230

Closed
ranjan-2209 opened this issue Sep 14, 2016 · 1 comment
Closed

sample tests where response is coming from https://www.luis.ai/ #1230

ranjan-2209 opened this issue Sep 14, 2016 · 1 comment
Assignees

Comments

@ranjan-2209
Copy link

ranjan-2209 commented Sep 14, 2016

What are these test for https://github.com/Microsoft/BotBuilder/tree/master/CSharp/Tests/Microsoft.Bot.Sample.Tests?

  1. To test Bot Framework, or

  2. To test the bot that I have created.

I am asking this because SetupLuis is used in SimpleAlarmBotTests.cs, which is a method of LuisTestBase class. And the parameter to SetupLuis is SetupLuis<SimpleAlarmDialog>(luis, a => a.SetAlarm(null, null), 1.0, entityTitle, entityDate, entityTime);. So this is pretty much obvious that we are not sending the request to LUIS: Language Understanding Intelligent Service (beta) and the request and response is being mocked. Its like testing 2 + 2 = 4. Kindly explain.

@ranjan-2209 ranjan-2209 changed the title https://github.com/Microsoft/BotBuilder/tree/master/CSharp/Tests/Microsoft.Bot.Sample.Tests sample tests where response is coming from https://www.luis.ai/ Sep 14, 2016
@willportnoy willportnoy self-assigned this Sep 16, 2016
@willportnoy
Copy link
Member

Those tests are to validate that the alarm sample works properly, not to check anything about the LUIS service. It's good practice to mock external dependencies so that the unit tests can run quickly without non-deterministic failures due to network conditions, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants