Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back insert-from-history #277

Open
lukeu opened this issue Mar 12, 2019 · 5 comments
Open

Bring back insert-from-history #277

lukeu opened this issue Mar 12, 2019 · 5 comments
Labels
approved Enhancement help wanted Issues identified as good community contribution opportunities Pri: 2

Comments

@lukeu
Copy link

lukeu commented Mar 12, 2019

Problem Statement
Easily insert result(s) from the history into an expression being composed, by simply clicking them.

Compared to typing out one single big expression using parenthesis, this proposal lets the user:

  • verify that results of sub-expressions look correct (in the history)
  • avoid duplication, for example in a ratio A / (A + B) , where A and B are the results of non-trivial expressions

Evidence or User Insights
Currently it is awkward and error-prone to reuse a results from history, and impossible(?) to combine results. This is a regression from the Win32 calculator, and differs from other software calculators with history (e.g. Android).

To illustrate, people familiar with other apps are likely to first wipe what they've written by clicking the history item. Being familiar with physical calculators they might next try something like:

  1. Click history item
  2. M+
  3. Start retyping the wiped expression

Huh, step 3 partially modified the history expression, weird. So before step 3 we needed to press ESC, fine. Start over. Oh no! There was now a value in memory and M+ doubled it. Right I should have used MS (but then, I have never owned a physical calculator with a MS button.) OK then: click MC (did I need to do that?) Press ESC. Start over again...

Even once the confusion is resolved, the process still takes a minimum of 3 steps, using 3 UI elements (the history item, MS, MR) where a single click could suffice. And it only works for one value.

Note that some scenarios are possible via Ctrl+C, but:

  • to Ctrl+C something from history wipes what you've typed - you still cannot combine history items
  • the UWP look does not make it obvious that Copy & Paste is available

Proposal
If an item is in the history (10*20 = 200) and a new expression is being typed...

  • ending in an operator (1 / ): clicking a history item should append the result (yielding: 1 / 200)
  • ending in an value (1 / 5): the final value should be replaced (1 / 200). This is for consistency with other buttons (like MR).

To overwrite the current expression, it should still be obvious and intuitive that you can click C or press ESC before clicking a history item - making both operations easily accessible.

Goals
To make the history pane more useful, via easy reuse of prior results.

Non-Goals
Inserting the entire expression from history into the current expression. (That would require a movable text cursor in the main expression editor, which is probably quite a UI departure.)

Low-Fidelity Concept
Constructing a 3rd expression from 2 prior expressions (by clicking them) in the Windows 7 Calculator:

win7_calc

Related

@MicrosoftIssueBot
Copy link
Collaborator

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

@grochocki
Copy link
Contributor

Thanks for the feature suggestion! This is really well thought-out, and we really appreciate it. Let's keep this idea open for discussion so the community has the chance to provide feedback. Check out our New Feedback Process for more info on the user-centered process we follow for new feature development.

@grochocki
Copy link
Contributor

We reviewed the pitch and would love to move forward with it. Since the idea is fairly straightforward and is entirely captured by the proposal, we can move this straight into production. @lukeu, if you are interested in implementing this one, let us know, otherwise we can open it up to the rest of the community.

@grochocki
Copy link
Contributor

@lukeu I am going to open this up to the community, but let us know if you still want to implement this!

@grochocki grochocki added the help wanted Issues identified as good community contribution opportunities label Aug 7, 2019
@lukeu
Copy link
Author

lukeu commented Aug 7, 2019

Hi sorry for the late reply (on a family trip). Yes by all means open it up, as I've not been finding much time for 'recreational' coding recently.

@grochocki grochocki added the hacktoberfest Hacktoberfest is a month-long celebration of open source software. label Sep 28, 2019
@grochocki grochocki removed the hacktoberfest Hacktoberfest is a month-long celebration of open source software. label Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Enhancement help wanted Issues identified as good community contribution opportunities Pri: 2
Projects
None yet
Development

No branches or pull requests

3 participants