Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify unit of column offsets #91

Closed
puremourning opened this issue Jan 16, 2020 · 4 comments
Closed

Specify unit of column offsets #91

puremourning opened this issue Jan 16, 2020 · 4 comments
Assignees
Labels
clarification Protocol clarification

Comments

@puremourning
Copy link
Contributor

Forgive me if I missed it, but I couldn't see a specification for the values of column offsets.

Examples:

  • Breakpoint locations
  • Stack trace locations
  • Completion request (assuming the text item is utf-8 encoded, what does the column items count ? bytes? or codepoints ? ).

I realise with LSP there is a bit of a fiasco with it being specified as UTF16 code units, is that also the assumption here?

@weinand weinand self-assigned this Jan 20, 2020
@weinand weinand added the clarification Protocol clarification label Jan 20, 2020
@weinand
Copy link
Contributor

weinand commented Jan 20, 2020

Today columns offsets are based on a UTF-16 string representation.
But we are planning to make this negotiable via DAP capabilities.

@puremourning
Copy link
Contributor Author

So they are like LSP; UTF-8 code units?

@weinand
Copy link
Contributor

weinand commented Jan 22, 2020

No, LSP is based on a UTF-16 string representation which means that it uses 16-bit code units.
And DAP uses the same.

@puremourning
Copy link
Contributor Author

Sorry yes I typod I mean utf 16 code units.

Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Protocol clarification
Projects
None yet
Development

No branches or pull requests

2 participants