Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 to test matrix #1667

Closed
AdamYoblick opened this issue Sep 6, 2024 · 8 comments
Closed

Add Python 3.13 to test matrix #1667

AdamYoblick opened this issue Sep 6, 2024 · 8 comments
Assignees

Comments

@AdamYoblick
Copy link
Member

No description provided.

@AdamYoblick AdamYoblick self-assigned this Sep 6, 2024
@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Sep 6, 2024
@AdamYoblick AdamYoblick removed the needs repro Issue has not been reproduced yet label Sep 6, 2024
@AdamYoblick
Copy link
Member Author

@judej @karthiknadig Karthik, Jude asked me to add Python 3.13 to the test matrix in anticipation of release. Unfortunately, 3.13 is not available to the Use Python Version Azdo task, so this step is failing for all platforms.

See https://dev.azure.com/debugpy/debugpy/_build/results?buildId=4228&view=logs&j=e545b7f1-8fae-520d-02ab-d6dba42df965&t=a282e492-efe7-5343-e9fe-8ee87399707a

I checked the task docs and I think it's failing because allowUnstable is set to false. I'll try it enabled and see what happens.

@AdamYoblick
Copy link
Member Author

Allowing unstable doesn't seem to make a difference. This is odd though because I checked the python-versions manifest file at https://github.com/actions/python-versions/blob/main/versions-manifest.json#L103 and I do see an unstable release for python 3.13 so I'm not sure why it can't be downloaded.

@karthiknadig
Copy link
Member

You may have to install 3.13 locally and test. GitHub actions typically has dev builds available. May be we need to keep test runner for dev builds on there.

@juliangilbey
Copy link

debugpy was just tested on Debian with Python 3.13 and failed several tests: the Debian bug report is here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1082090 (and it gives a link to full test logs which will be available for the next 30 days).

Best wishes, Julian

@AdamYoblick
Copy link
Member Author

debugpy was just tested on Debian with Python 3.13 and failed several tests: the Debian bug report is here: bugs.debian.org/cgi-bin/bugreport.cgi?bug=1082090 (and it gives a link to full test logs which will be available for the next 30 days).

Best wishes, Julian

Thank you for this! I've downloaded the full logs and put it on my OneDrive. People from MS can get it at https://microsoft-my.sharepoint.com/:t:/p/advolker/EVNkdfQR8jVHnV9qEkv-xOEB_Mq6Vu6SZK_T2vYtkVCixw?e=mXCxgb

@AdamYoblick
Copy link
Member Author

Looks like I was able to attach it to this issue as well.

log.txt

@rchiodo
Copy link
Contributor

rchiodo commented Sep 23, 2024

This commit in CPython changes how _is_stopped is computed. This is likely breaking stuff because pydevd looks directly at this attribute.

python/cpython@33da0e8#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0

We need to fix all of the spots were we call thread._is_stopped to instead use thread._handle.is_done()

@rchiodo
Copy link
Contributor

rchiodo commented Oct 10, 2024

This should be part of the test matrix now.

@rchiodo rchiodo closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants