Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inject version into fast-element source #6556

Open
EisenbergEffect opened this issue Dec 6, 2022 · 1 comment
Open

feat: inject version into fast-element source #6556

EisenbergEffect opened this issue Dec 6, 2022 · 1 comment
Labels
area:fast-element Pertains to fast-element community:noteworthy An issue or PR of particular interest to the community or planned for an announcement. feature A new feature status:planned Work is planned

Comments

@EisenbergEffect
Copy link
Contributor

🙋 Feature Request

The FASTGlobal has a versions array. Instances of fast-element should push their version number into the array if it is not already present. This will enable easy detection of multiple versions as well as which versions are loaded.

🤔 Expected Behavior

FAST.versions should return an array of loaded fast-element versions.

😯 Current Behavior

The array is empty.

💁 Possible Solution

This will need to be accomplished through a combination of a small amount of code added to fast-element along with beachball integration. Here is the relevant beachball issue:

🔦 Context

It would be nice to know what version or versions are loaded at runtime.

💻 Examples

console.log(FAST.versions); // ['2.0.0']
@EisenbergEffect EisenbergEffect added feature A new feature status:planned Work is planned area:fast-element Pertains to fast-element community:noteworthy An issue or PR of particular interest to the community or planned for an announcement. labels Dec 6, 2022
@EisenbergEffect EisenbergEffect added this to the FAST Element 2.0 milestone Dec 6, 2022
@KingOfTac
Copy link
Collaborator

Would this ultimately help fix the instanceof check errors on FASTElement, or is there no way around that other than just making sure you're not loading multiple versions of the library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:fast-element Pertains to fast-element community:noteworthy An issue or PR of particular interest to the community or planned for an announcement. feature A new feature status:planned Work is planned
Projects
Status: Triage
Development

No branches or pull requests

3 participants