You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is now very easy for downstream consumers that depend on leaf packages only (which don't import any other upper-case "github.com/Microsoft/..." packages) to accidentally clone and add imports to lower-case "github.com/microsoft/..." packages. This will work in isolation, but as soon as their library has to coexist in a build with any other component which used the canonical "github.com/Microsoft/..." imports, builds will start failing.
(This was possible before, but way harder to do accidentally, since all the links and clone commands from github agreed with the canonical go import packages)
Thanks Jordan. These are good suggestions. We are discussing internally what we want to do across Microsoft's go repos so that we can have a consistent approach.
The github.com/Microsoft org was just renamed to github.com/microsoft
This means that the canonical github repo address now conflicts with canonical go import packages (for example,
"github.com/Microsoft/hcsshim/internal/hcserror"
, as referenced from https://github.com/microsoft/hcsshim/blob/master/hcsshim.go#L9)It is now very easy for downstream consumers that depend on leaf packages only (which don't import any other upper-case "github.com/Microsoft/..." packages) to accidentally clone and add imports to lower-case
"github.com/microsoft/..."
packages. This will work in isolation, but as soon as their library has to coexist in a build with any other component which used the canonical"github.com/Microsoft/..."
imports, builds will start failing.(This was possible before, but way harder to do accidentally, since all the links and clone commands from github agreed with the canonical go import packages)
Context:
Cautionary tale:
Also filed in the other Microsoft dependency we use in Kubernetes:
microsoft/go-winio#135
Please consider reverting the
Microsoft
->microsoft
rename.cc @jeffwilcox
The text was updated successfully, but these errors were encountered: