Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes Engine takes at least 2x more time to resolve promises.all than Chakra #183

Open
i-xarlos opened this issue May 24, 2024 · 1 comment

Comments

@i-xarlos
Copy link

          @AlexLablaiksSAP I am reopening the issue.

As we discussed with your team today, I clearly see the same issue playing with your repro.
From what I see in the WPA (Windows Perf Analysis tooling), where are no significant delays in the JS thread. The most of time is spent inside of the Hermes interpreter. The function that seems to be the most expensive is the Array.indexOf().
image

The next steps:

  • Discuss this issue with Meta's Hermes team
  • I would like to see the Hermes CPU sampling profiler results. I need to use the latest Hermes bit for it.

Originally posted by @vmoroz in #92 (comment)

@i-xarlos i-xarlos changed the title @AlexLablaiksSAP I am reopening the issue. Hermes Engine takes at least 2x more time to resolve promises.all than Chakra May 24, 2024
@i-xarlos
Copy link
Author

i-xarlos commented May 24, 2024

In tests we have done it can be verified:

Hermes engine for windows takes at least twice (2X) as long to resolve promise.all, doesn't matter if it's Intel or AMD the results are the same. Using Chakra engine takes half the time in all tests.

The impact that we have verified is in the lower index that is verified in this description: #92

Technical details of the machines where the tests were carried out using 160 promises (Promise.All):

Operating system
Name: Microsoft Windows 11 Home
Version: 10.0.22631

Dependencies for React Native Windows:
"react": "18.2.0"
"react-native": "0.72.7"
"react-native-windows": "0.72.32"

Processor & Memory
Processor: AMD Ryzen 3 7320U with Radeon Graphics
Physical memory: 8 GiB

Processor & Memory
Processor: AMD Ryzen 7 7736U with Radeon Graphics
Physical memory: 16 GiB

Processor & Memory
Processor: Intel(R) Core(TM) 7 150U
Physical memory: 16 GiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant