Feat/auth handler #1562
Draft
Feat/auth handler #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested changes
Sep 11, 2024
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public class ContinuousAccessEvaluationClaims { |
There was a problem hiding this comment.
could we restrict this to package instead?
There was a problem hiding this comment.
Wouldn't be possible since it's used both under the ...http and ...http.middleware packages.
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Show resolved
Hide resolved
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Outdated
Show resolved
Hide resolved
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Outdated
Show resolved
Hide resolved
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Outdated
Show resolved
Hide resolved
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Outdated
Show resolved
Hide resolved
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Outdated
Show resolved
Hide resolved
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Outdated
Show resolved
Hide resolved
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Vincent Biret <[email protected]>
Ndiritu
force-pushed
the
feat/auth-handler
branch
from
293575b
to
5fa1f82
Compare
baywet
reviewed
Sep 27, 2024
| * Helper class to extract the claims from the WWW-Authenticate header in a response. | ||
| * https://learn.microsoft.com/en-us/entra/identity/conditional-access/concept-continuous-access-evaluation | ||
| */ | ||
| public final class ContinuousAccessEvaluationClaims { |
There was a problem hiding this comment.
do we need this class to be public? can't we restrain it to package so we're not shipping additional API on this side?
There was a problem hiding this comment.
It's being used in the com.microsoft.kiota.http package and com.microsoft.kiota.http.middleware package.
Restricting it would make it only visible in the main http package and not in the middleware package and vice versa. Java doesn't have an equivalent of internal in .NET
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Outdated
Show resolved
Hide resolved
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Outdated
Show resolved
Hide resolved
Ndiritu
force-pushed
the
feat/auth-handler
branch
from
86923aa
to
08c471b
Compare
Co-authored-by: Vincent Biret <[email protected]>
Ndiritu
force-pushed
the
feat/auth-handler
branch
from
2d9ccc7
to
c9f333c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes microsoftgraph/msgraph-sdk-java#2096